src,lib: reducing C++ calls of esm legacy main resolve #48325

H4ad · 2023-06-03T19:41:39Z

This PR is related to nodejs/performance#73

Legacy Main Resolve

@anonrig raised that we could benefit from the implementation of legacyMainResolve on the C++ side, so here's the result so far:

                                                                                                                                                                confidence improvement accuracy (*)
esm/esm-legacyMainResolve.js resolvedFile='node_modules/non-exist' packageConfigMain='./index.js' packageJsonUrl='node_modules/test/package.json' n=10000              ***     34.86 %       ±1.41%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/non-exist' packageConfigMain='' packageJsonUrl='node_modules/test/package.json' n=10000                        ***     34.92 %       ±1.52%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.js' packageConfigMain='./index.js' packageJsonUrl='node_modules/test/package.json' n=10000          ***     34.53 %       ±1.22%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.js' packageConfigMain='' packageJsonUrl='node_modules/test/package.json' n=10000                    ***     35.39 %       ±1.57%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.json' packageConfigMain='./index.js' packageJsonUrl='node_modules/test/package.json' n=10000        ***     34.78 %       ±1.30%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.json' packageConfigMain='' packageJsonUrl='node_modules/test/package.json' n=10000                  ***     35.39 %       ±1.15%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.node' packageConfigMain='./index.js' packageJsonUrl='node_modules/test/package.json' n=10000        ***     34.75 %       ±1.43%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.node' packageConfigMain='' packageJsonUrl='node_modules/test/package.json' n=10000                  ***     35.84 %       ±1.33%
                                                                                                                                                                  (**)  (***)
esm/esm-legacyMainResolve.js resolvedFile='node_modules/non-exist' packageConfigMain='./index.js' packageJsonUrl='node_modules/test/package.json' n=10000       ±1.88% ±2.45%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/non-exist' packageConfigMain='' packageJsonUrl='node_modules/test/package.json' n=10000                 ±2.02% ±2.64%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.js' packageConfigMain='./index.js' packageJsonUrl='node_modules/test/package.json' n=10000   ±1.62% ±2.12%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.js' packageConfigMain='' packageJsonUrl='node_modules/test/package.json' n=10000             ±2.09% ±2.74%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.json' packageConfigMain='./index.js' packageJsonUrl='node_modules/test/package.json' n=10000 ±1.74% ±2.27%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.json' packageConfigMain='' packageJsonUrl='node_modules/test/package.json' n=10000           ±1.53% ±1.99%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.node' packageConfigMain='./index.js' packageJsonUrl='node_modules/test/package.json' n=10000 ±1.91% ±2.48%
esm/esm-legacyMainResolve.js resolvedFile='node_modules/test/index.node' packageConfigMain='' packageJsonUrl='node_modules/test/package.json' n=10000           ±1.77% ±2.31%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 8 comparisons, you can thus
expect the following amount of false-positive results:
  0.40 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.08 false positives, when considering a   1% risk acceptance (**, ***),
  0.01 false positives, when considering a 0.1% risk acceptance (***)

To be able to run the benchmark, first build the old node using this branch.

About the benchmark, I needed to create another benchmark just for this function to be able to see the improvements since the results of esm-defaultResolver.js was not reflecting the real impact of this change.

Potential optimizations

legacyMainResolve also calls fileURLToPath and didn't have any version on the C++ side, so I needed to rewrite this function.

I haven't benchmarked the JS version yet, but I think we can add some benchmarks and see if we can replace the JS version with the C++ version, I've tried to make the code as easy as possible to support exposing on the JS side in the future.

Tasks

Rewrite legacyMainResolve
Rewrite fileURLToPath
Add benchmark for legacyMainResolve
Add tests for legacyMainResolve

Acknowledgments

Huge thanks to @anonrig for the support and early review of this code and @RafaelGSS for the hints about the benchmark and permission model.

nodejs-github-bot · 2023-06-03T19:41:43Z

Review requested:

@nodejs/loaders
@nodejs/modules

RafaelGSS

IMO the new implementation is prone to memory leaks and it's quite complex to read

src/node_errors.h

src/node_file.cc

RafaelGSS · 2023-06-03T21:03:14Z

src/node_file.cc

+    THROW_IF_INSUFFICIENT_PERMISSIONS(
+        env, permission::PermissionScope::kFileSystemRead, file_path);
+
+    if (UNSAFE_FileExist(env, file_path)) return args.GetReturnValue().Set(0);


Wouldn't it block the event loop?

lib/internal/modules/esm/resolve.js

src/node_file.cc

src/node_errors.h

src/node_file.cc

debadree25 · 2023-06-04T05:57:56Z

src/node_file.cc

+#endif
+}
+
+FilePathIsFileReturnType FilePathIsFile(Environment* env,


This function seems to be the same as

node/src/node_file.cc

Line 1124 in 4bb06db

static void InternalModuleStat(const FunctionCallbackInfo<Value>& args) {

maybe we could DRY the implementation of both here? (this not really blocking just a observation)

Initially, I was thinking of doing that but I cannot join both functions since I don't know how I can represent the state of the THROW_IF_INSUFFICIENT_PERMISSIONS, when the user doesn't have permissions, we should stop the execution of the function, so I need to return not only an int but also another state to tell the caller that the user doesn't have permission.

Because of this, I prefer to return an enum for FilePathIsFile and not over complicate both implementations.

@RafaelGSS might help

aduh95 · 2023-06-04T08:38:39Z

legacyMainResolve also calls fileURLToPath and didn't have any version on the C++ side, so I needed to rewrite this function.

Maybe we should first test/benchmark and land the fileURLToPath rewrite, which would simplify this PR. wdyt?

H4ad · 2023-06-04T17:30:48Z

@aduh95 Here's the benchmark for the rewrite of fileURLToPath:

IMPORTANT: Those values are not related to this PR, those numbers are only specific to the branch linked above the benchmark.

                                                                                         confidence improvement accuracy (*)    (**)   (***)
url/file-url-to-path.js n=100000 url='(url) file:///home/user/test/index.js'                    ***    -95.88 %       ±3.25%  ±4.44%  ±6.03%
url/file-url-to-path.js n=100000 url='(url) file:///home/user/test%20index.js'                  ***    -95.19 %       ±2.98%  ±4.07%  ±5.52%
url/file-url-to-path.js n=100000 url='(url) file:///home/user/test%2Findex.js'                  ***      8.66 %       ±2.71%  ±3.67%  ±4.90%
url/file-url-to-path.js n=100000 url='(url) file://google.com/home/user/test%2Findex.js'                 0.68 %       ±2.75%  ±3.72%  ±4.99%
url/file-url-to-path.js n=100000 url='(url) http://google.com/home/test.js'                     ***    -11.02 %       ±2.27%  ±3.05%  ±4.03%
url/file-url-to-path.js n=100000 url='file:///home/user/test/index.js'                          ***     97.59 %       ±7.74% ±10.45% ±13.92%
url/file-url-to-path.js n=100000 url='file:///home/user/test%20index.js'                        ***     86.08 %       ±7.51% ±10.15% ±13.52%
url/file-url-to-path.js n=100000 url='file:///home/user/test%2Findex.js'                        ***    195.47 %       ±3.95%  ±5.35%  ±7.14%
url/file-url-to-path.js n=100000 url='file://google.com/home/user/test%2Findex.js'              ***    166.80 %       ±3.19%  ±4.29%  ±5.66%
url/file-url-to-path.js n=100000 url='http://google.com/home/test.js'                           ***    145.18 %       ±4.26%  ±5.76%  ±7.68%
url/file-url-to-path.js n=100000 url='not-even-a-url'                                           ***    168.09 %       ±7.25%  ±9.87% ±13.32%

Be aware that when doing many comparisons the risk of a false-positive
result increases. In this case, there are 11 comparisons, you can thus
expect the following amount of false-positive results:
  0.55 false positives, when considering a   5% risk acceptance (*, **, ***),
  0.11 false positives, when considering a   1% risk acceptance (**, ***),
  0.01 false positives, when considering a 0.1% risk acceptance (***)

Branch: main...h4ad-forks:node:perf/file-url-to-path

In resume, if we want to expose the C++ function, we should enforce the caller to always pass a string instead of URL.

aduh95 · 2023-06-04T23:03:51Z

@H4ad I meant to have it as a separate PR.

lib/internal/modules/esm/resolve.js

src/node_file.cc

H4ad · 2023-06-04T23:41:03Z

@aduh95 Yeah, my idea was to show you if you really want to do that with the performance benefits from it.

To be honest, in this form, without refactoring the whole ESM to avoid new URL and manipulate the data directly as a string, we will not see a performance improvement, it will be the complete opposite.

I think is better to go in the opposite direction, merge this one and then evaluate the benefits of exposing fileURLToPath, because as I said, will probably lead to a refactoring not only in the function itself but also in the places where they call to take the fastest path, which is manipulating directly the string.

GeoffreyBooth · 2023-06-05T21:31:45Z

url/file-url-to-path.js n=100000 url=’(url) file:///home/user/test/index.js’ *** -95.88 % ±3.25% ±4.44% ±6.03%

This seems to show that in the most common case of a file:// URL, this is 96% slower?

H4ad · 2023-06-06T00:50:33Z

@GeoffreyBooth Exactly, the way the fileURLToPath is used today, simply don't worth exposing the C++ version.

GeoffreyBooth · 2023-06-06T00:52:00Z

@GeoffreyBooth Exactly, the way the fileURLToPath is used today, simply don’t worth exposing the C++ version.

Okay, so then should we close this PR? Is there something else of value being proposed here?

H4ad · 2023-06-06T00:59:38Z

This PR is not about fileURLToPath, is about LegacyMainResolve.

The improvements for LegacyMainResolve is about 60~70%.

The rewrite of fileURLToPath was only because it was needed by LegacyMainResolve. Aduh suggested that maybe we could create a PR for fileURLToPath but as we've seen, it's not worth it, that's it.

Also, the metrics of #48325 (comment) is not related to this PR itself, are related to the branch I link in the comment, so those numbers don't reflect this PR since we don't have any overhead of calling C++ function from C++ side.

H4ad · 2023-06-07T19:57:43Z

The CI for Test Asan is failing due some memory issue:

==88318==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7ffd9ad085f8 at pc 0x00000431f995 bp 0x7ffd9ad07570 sp 0x7ffd9ad07568
READ of size 16 at 0x7ffd9ad085f8 thread T0
    #0 0x431f994 in ada::url_aggregator ada::parser::parse_url<ada::url_aggregator>(std::basic_string_view<char, std::char_traits<char> >, ada::url_aggregator const*) (/home/runner/work/node/node/out/Release/node+0x431f994)
    #1 0x4312e13 in tl::expected<ada::url_aggregator, ada::errors> ada::parse<ada::url_aggregator>(std::basic_string_view<char, std::char_traits<char> >, ada::url_aggregator const*) (/home/runner/work/node/node/out/Release/node+0x4312e13)
    #2 0xfc3b97 in node::fs::LegacyMainResolve(v8::FunctionCallbackInfo<v8::Value> const&) (/home/runner/work/node/node/out/Release/node+0xfc3b97)
    #3 0x1779bab in v8::internal::MaybeHandle<v8::internal::Object> v8::internal::(anonymous namespace)::HandleApiCallHelper<false>(v8::internal::Isolate*, v8::internal::Handle<v8::internal::HeapObject>, v8::internal::Handle<v8::internal::FunctionTemplateInfo>, v8::internal::Handle<v8::internal::Object>, unsigned long*, int) (/home/runner/work/node/node/out/Release/node+0x1779bab)
    #4 0x17779b4 in v8::internal::Builtin_HandleApiCall(int, unsigned long*, v8::internal::Isolate*) (/home/runner/work/node/node/out/Release/node+0x17779b4)
    #5 0x3402e35 in Builtins_CEntry_Return1_ArgvOnStack_BuiltinExit (/home/runner/work/node/node/out/Release/node+0x3402e35)

Address 0x7ffd9ad085f8 is located in stack of thread T0 at offset 1304 in frame
    #0 0xfc364f in node::fs::LegacyMainResolve(v8::FunctionCallbackInfo<v8::Value> const&) (/home/runner/work/node/node/out/Release/node+0xfc364f)

Ref: https://github.com/nodejs/node/actions/runs/5189308542/jobs/9354128411?pr=48325

Does anyone know what could be the cause?

I tried to reproduce it locally but I couldn't, so I have no idea how to fix it.

src/node_file.cc

Backport-PR-URL: nodejs#48325

PR-URL: #48664 Refs: #48325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>

Instead of many C++ calls, now we make only one C++ call to return a enum number that represents the selected state. Backport-PR-URL: nodejs#48325

Backport-PR-URL: nodejs#48325

PR-URL: #49688 Refs: #48325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: nodejs#49688 Refs: nodejs#48325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: #49688 Refs: #48325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Instead of many C++ calls, now we make only one C++ call to return a enum number that represents the selected state. Backport-PR-URL: nodejs#48325

Backport-PR-URL: nodejs#48325

PR-URL: nodejs#48664 Refs: nodejs#48325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Backport-PR-URL: nodejs#48664

PR-URL: nodejs#49688 Refs: nodejs#48325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

nodejs/node#48325

* chore: bump Node.js to v22.9.0 * build: drop base64 dep in GN build nodejs/node#52856 * build,tools: make addons tests work with GN nodejs/node#50737 * fs: add fast api for InternalModuleStat nodejs/node#51344 * src: move package_json_reader cache to c++ nodejs/node#50322 * crypto: disable PKCS#1 padding for privateDecrypt nodejs-private/node-private#525 * src: move more crypto code to ncrypto nodejs/node#54320 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * src: shift more crypto impl details to ncrypto nodejs/node#54028 * src: switch crypto APIs to use Maybe<void> nodejs/node#54775 * crypto: remove DEFAULT_ENCODING nodejs/node#47182 * deps: update libuv to 1.47.0 nodejs/node#50650 * build: fix conflict gyp configs nodejs/node#53605 * lib,src: drop --experimental-network-imports nodejs/node#53822 * esm: align sync and async load implementations nodejs/node#49152 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * module: detect ESM syntax by trying to recompile as SourceTextModule nodejs/node#52413 * test: adapt debugger tests to V8 11.4 nodejs/node#49639 * lib: update usage of always on Atomics API nodejs/node#49639 * test: adapt test-fs-write to V8 internal changes nodejs/node#49639 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * deps: update libuv to 1.47.0 nodejs/node#50650 * src: use non-deprecated v8::Uint8Array::kMaxLength nodejs/node#50115 * src: update default V8 platform to override functions with location nodejs/node#51362 * src: add missing TryCatch nodejs/node#51362 * lib,test: handle new Iterator global nodejs/node#51362 * src: use non-deprecated version of CreateSyntheticModule nodejs/node#50115 * src: remove calls to recently deprecated V8 APIs nodejs/node#52996 * src: use new V8 API to define stream accessor nodejs/node#53084 * src: do not use deprecated V8 API nodejs/node#53084 * src: do not use soon-to-be-deprecated V8 API nodejs/node#53174 * src: migrate to new V8 interceptors API nodejs/node#52745 * src: use supported API to get stalled TLA messages nodejs/node#51362 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * test: make snapshot comparison more flexible nodejs/node#54375 * test: do not set concurrency on parallelized runs nodejs/node#52177 * src: move FromNamespacedPath to path.cc nodejs/node#53540 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * build: add option to enable clang-cl on Windows nodejs/node#52870 * chore: fixup patch indices * chore: add/remove changed files * esm: drop support for import assertions nodejs/node#54890 * build: compile with C++20 support nodejs/node#52838 * deps: update nghttp2 to 1.62.1 nodejs/node#52966 * src: parse inspector profiles with simdjson nodejs/node#51783 * build: add GN build files nodejs/node#47637 * deps,lib,src: add experimental web storage nodejs/node#52435 * build: add missing BoringSSL dep * src: rewrite task runner in c++ nodejs/node#52609 * fixup! build: add GN build files * src: stop using deprecated fields of v8::FastApiCallbackOptions nodejs/node#54077 * fix: shadow variable * build: add back incorrectly removed SetAccessor patch * fixup! fixup! build: add GN build files * crypto: fix integer comparison in crypto for BoringSSL * src,lib: reducing C++ calls of esm legacy main resolve nodejs/node#48325 * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * chore: fixup GN files for previous commit * src: move more crypto code to ncrypto nodejs/node#54320 * Fixup Perfetto ifdef guards * fix: missing electron_natives dep * fix: node_use_node_platform = false * fix: include src/node_snapshot_stub.cc in libnode * 5507047: [import-attributes] Remove support for import assertions https://chromium-review.googlesource.com/c/v8/v8/+/5507047 * fix: restore v8-sandbox.h in filenames.json * fix: re-add original-fs generation logic * fix: ngtcp2 openssl dep * test: try removing NAPI_VERSION undef * chore(deps): bump @types/node * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * buffer: fix out of range for toString nodejs/node#54553 * lib: rewrite AsyncLocalStorage without async_hooks nodejs/node#48528 * module: print amount of load time of a cjs module nodejs/node#52213 * test: skip reproducible snapshot test on 32-bit nodejs/node#53592 * fixup! src: move more crypto_dh.cc code to ncrypto * test: adjust emittedUntil return type * chore: remove redundant wpt streams patch * fixup! chore(deps): bump @types/node * fix: gn executable name on Windows * fix: build on Windows * fix: rename conflicting win32 symbols in //third_party/sqlite On Windows otherwise we get: lld-link: error: duplicate symbol: sqlite3_win32_write_debug >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_sleep >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_is_nt >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj * docs: remove unnecessary ts-expect-error after types bump * src: move package resolver to c++ nodejs/node#50322 * build: set ASAN detect_container_overflow=0 nodejs/node#55584 * chore: fixup rebase * test: disable failing ASAN test * win: almost fix race detecting ESRCH in uv_kill libuv/libuv#4341

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. esm Issues and PRs related to the ECMAScript Modules implementation. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 3, 2023

H4ad force-pushed the perf/legacy-main-resolve branch from 95e1aa7 to 55dd4d9 Compare June 3, 2023 19:43

H4ad mentioned this pull request Jun 3, 2023

Improve legacy CJS resolve nodejs/performance#73

Closed

RafaelGSS reviewed Jun 3, 2023

View reviewed changes

This comment was marked as duplicate.

Sign in to view

anonrig reviewed Jun 3, 2023

View reviewed changes

lib/internal/modules/esm/resolve.js Outdated Show resolved Hide resolved

lib/internal/modules/esm/resolve.js Outdated Show resolved Hide resolved

src/node_file.cc Outdated Show resolved Hide resolved

src/node_file.cc Outdated Show resolved Hide resolved

H4ad force-pushed the perf/legacy-main-resolve branch 2 times, most recently from 232d48c to 072c7d2 Compare June 4, 2023 03:21

anonrig reviewed Jun 4, 2023

View reviewed changes

debadree25 reviewed Jun 4, 2023

View reviewed changes

H4ad force-pushed the perf/legacy-main-resolve branch from 072c7d2 to dbacd5f Compare June 4, 2023 15:33

RafaelGSS reviewed Jun 4, 2023

View reviewed changes

H4ad force-pushed the perf/legacy-main-resolve branch from dbacd5f to 9301722 Compare June 5, 2023 02:29

H4ad marked this pull request as ready for review June 5, 2023 02:30

anonrig mentioned this pull request Jun 5, 2023

Node.js Technical Steering Committee (TSC) Meeting 2023-06-07 nodejs/TSC#1396

Closed

H4ad force-pushed the perf/legacy-main-resolve branch from 9301722 to 42f276c Compare June 6, 2023 13:43

RaisinTen reviewed Jun 8, 2023

View reviewed changes

src/node_file.cc Outdated Show resolved Hide resolved

H4ad added a commit to H4ad/node that referenced this pull request Sep 14, 2023

fixup! src,lib: reducing C++ calls of esm legacy main resolve

aed4c4b

Backport-PR-URL: nodejs#48325

H4ad mentioned this pull request Sep 14, 2023

[v18.x backport] src,lib: reducing C++ calls of esm legacy main resolve #49644

Closed

RaisinTen added backport-open-v18.x Indicate that the PR has an open backport. and removed backport-requested-v18.x PRs awaiting manual backport to the v18.x-staging branch. labels Sep 14, 2023

pluris mentioned this pull request Sep 16, 2023

src: move const variable in node_file.h to node_file.cc #49673

Closed

pluris mentioned this pull request Sep 17, 2023

src: move const variable in node_file.h to node_file.cc #49688

Merged

H4ad added a commit to H4ad/node that referenced this pull request Sep 18, 2023

src,lib: reducing C++ calls of esm legacy main resolve

9bfc75e

Instead of many C++ calls, now we make only one C++ call to return a enum number that represents the selected state. Backport-PR-URL: nodejs#48325

H4ad added a commit to H4ad/node that referenced this pull request Sep 18, 2023

fixup! src,lib: reducing C++ calls of esm legacy main resolve

3a1addf

Backport-PR-URL: nodejs#48325

H4ad added a commit to H4ad/node that referenced this pull request Sep 18, 2023

fixup! src,lib: reducing C++ calls of esm legacy main resolve

41c762e

Backport-PR-URL: nodejs#48325

nodejs-github-bot pushed a commit that referenced this pull request Sep 29, 2023

src: move const variable in node_file.h to node_file.cc

43500fa

PR-URL: #49688 Refs: #48325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

alexfernandez pushed a commit to alexfernandez/node that referenced this pull request Nov 1, 2023

src: move const variable in node_file.h to node_file.cc

28d2e2b

PR-URL: nodejs#49688 Refs: nodejs#48325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

targos pushed a commit that referenced this pull request Nov 11, 2023

src: move const variable in node_file.h to node_file.cc

ba169be

PR-URL: #49688 Refs: #48325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

H4ad added a commit to H4ad/node that referenced this pull request Dec 2, 2023

src,lib: reducing C++ calls of esm legacy main resolve

f260c35

Instead of many C++ calls, now we make only one C++ call to return a enum number that represents the selected state. Backport-PR-URL: nodejs#48325

H4ad added a commit to H4ad/node that referenced this pull request Dec 2, 2023

fixup! src,lib: reducing C++ calls of esm legacy main resolve

edbc6b5

Backport-PR-URL: nodejs#48325

This was referenced Feb 14, 2024

[Bug]: Electron 29. "Cannot Find Packages" when targeting ESM electron/electron#41241

Closed

fix: ESM legacyMainResolve with asar electron/electron#41348

Closed

VerteDinde mentioned this pull request Feb 18, 2024

fix: revert to legacyMainResolve in JavaScript for asar compatibility electron/electron#41367

Merged

5 tasks

richardlau removed the backport-open-v18.x Indicate that the PR has an open backport. label Mar 18, 2024

debadree25 pushed a commit to debadree25/node that referenced this pull request Apr 15, 2024

src: move const variable in node_file.h to node_file.cc

c18b114

PR-URL: nodejs#49688 Refs: nodejs#48325 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

codebytere added a commit to electron/electron that referenced this pull request Oct 18, 2024

src,lib: reducing C++ calls of esm legacy main resolve

08cf732

nodejs/node#48325

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

src,lib: reducing C++ calls of esm legacy main resolve

6bea893

nodejs/node#48325

codebytere added a commit to electron/electron that referenced this pull request Oct 21, 2024

src,lib: reducing C++ calls of esm legacy main resolve

bc03805

nodejs/node#48325

codebytere added a commit to electron/electron that referenced this pull request Oct 22, 2024

src,lib: reducing C++ calls of esm legacy main resolve

330374d

nodejs/node#48325

codebytere added a commit to electron/electron that referenced this pull request Oct 28, 2024

src,lib: reducing C++ calls of esm legacy main resolve

1948919

nodejs/node#48325

codebytere added a commit to electron/electron that referenced this pull request Oct 29, 2024

src,lib: reducing C++ calls of esm legacy main resolve

433d672

nodejs/node#48325

codebytere added a commit to electron/electron that referenced this pull request Oct 31, 2024

src,lib: reducing C++ calls of esm legacy main resolve

23e7ee1

nodejs/node#48325

aduh95 mentioned this pull request Nov 3, 2024

[v18.x] esm: fix broken assertion in legacyMainResolve #55708

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

src,lib: reducing C++ calls of esm legacy main resolve #48325

src,lib: reducing C++ calls of esm legacy main resolve #48325

H4ad commented Jun 3, 2023 •

edited

Loading

nodejs-github-bot commented Jun 3, 2023

RafaelGSS left a comment

RafaelGSS Jun 3, 2023

This comment was marked as duplicate.

debadree25 Jun 4, 2023

H4ad Jun 4, 2023

anonrig Jun 10, 2023

aduh95 commented Jun 4, 2023

H4ad commented Jun 4, 2023 •

edited

Loading

aduh95 commented Jun 4, 2023

H4ad commented Jun 4, 2023

GeoffreyBooth commented Jun 5, 2023

H4ad commented Jun 6, 2023

GeoffreyBooth commented Jun 6, 2023

H4ad commented Jun 6, 2023 •

edited

Loading

H4ad commented Jun 7, 2023

src,lib: reducing C++ calls of esm legacy main resolve #48325

src,lib: reducing C++ calls of esm legacy main resolve #48325

Conversation

H4ad commented Jun 3, 2023 • edited Loading

Legacy Main Resolve

Potential optimizations

Tasks

Acknowledgments

nodejs-github-bot commented Jun 3, 2023

RafaelGSS left a comment

Choose a reason for hiding this comment

RafaelGSS Jun 3, 2023

Choose a reason for hiding this comment

This comment was marked as duplicate.

debadree25 Jun 4, 2023

Choose a reason for hiding this comment

H4ad Jun 4, 2023

Choose a reason for hiding this comment

anonrig Jun 10, 2023

Choose a reason for hiding this comment

aduh95 commented Jun 4, 2023

H4ad commented Jun 4, 2023 • edited Loading

aduh95 commented Jun 4, 2023

H4ad commented Jun 4, 2023

GeoffreyBooth commented Jun 5, 2023

H4ad commented Jun 6, 2023

GeoffreyBooth commented Jun 6, 2023

H4ad commented Jun 6, 2023 • edited Loading

H4ad commented Jun 7, 2023

H4ad commented Jun 3, 2023 •

edited

Loading

H4ad commented Jun 4, 2023 •

edited

Loading

H4ad commented Jun 6, 2023 •

edited

Loading