deps: update V8 to 11.9 #50115
Closed
deps: update V8 to 11.9 #50115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
nodejs-github-bot
added
build
targos
added
semver-major
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
30 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Nov 6, 2023
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Nov 8, 2023
bmeck
pushed a commit
to bmeck/node
that referenced
this pull request
Jun 22, 2024
Semver-Major Commits: build: * (SEMVER-MAJOR) compile with C++20 support on Windows (StefanStojanovic) nodejs#52465 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) nodejs#49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) nodejs#52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) nodejs#51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) nodejs#50973 deps: * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) nodejs#52465 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#52465 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) update V8 to 12.4.254.14 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) nodejs#52293 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) nodejs#52293 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) nodejs#52293 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) nodejs#51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) nodejs#51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) nodejs#50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) nodejs#50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) nodejs#51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) nodejs#51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) nodejs#50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) nodejs#52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) nodejs#51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) nodejs#50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) nodejs#50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) nodejs#51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) nodejs#51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) nodejs#52172 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 127 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) nodejs#51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) nodejs#50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) nodejs#52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) nodejs#50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) nodejs#52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) nodejs#51577 tools: * (SEMVER-MAJOR) update V8 gypfiles for 12.4 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) nodejs#51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) nodejs#51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) nodejs#50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) nodejs#51360 PR-URL: nodejs#52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 16, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 16, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 16, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 16, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 21, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 21, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 21, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 21, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 21, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 21, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 21, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 21, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 22, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 22, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 22, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 22, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 28, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 28, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 28, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 28, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 29, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 29, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 29, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 29, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 31, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 31, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 31, 2024
codebytere
added a commit
to electron/electron
that referenced
this pull request
Oct 31, 2024
jkleinsc
pushed a commit
to electron/electron
that referenced
this pull request
Nov 4, 2024
* chore: bump Node.js to v22.9.0 * build: drop base64 dep in GN build nodejs/node#52856 * build,tools: make addons tests work with GN nodejs/node#50737 * fs: add fast api for InternalModuleStat nodejs/node#51344 * src: move package_json_reader cache to c++ nodejs/node#50322 * crypto: disable PKCS#1 padding for privateDecrypt nodejs-private/node-private#525 * src: move more crypto code to ncrypto nodejs/node#54320 * crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey nodejs/node#50234 * src: shift more crypto impl details to ncrypto nodejs/node#54028 * src: switch crypto APIs to use Maybe<void> nodejs/node#54775 * crypto: remove DEFAULT_ENCODING nodejs/node#47182 * deps: update libuv to 1.47.0 nodejs/node#50650 * build: fix conflict gyp configs nodejs/node#53605 * lib,src: drop --experimental-network-imports nodejs/node#53822 * esm: align sync and async load implementations nodejs/node#49152 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * module: detect ESM syntax by trying to recompile as SourceTextModule nodejs/node#52413 * test: adapt debugger tests to V8 11.4 nodejs/node#49639 * lib: update usage of always on Atomics API nodejs/node#49639 * test: adapt test-fs-write to V8 internal changes nodejs/node#49639 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * deps: update libuv to 1.47.0 nodejs/node#50650 * src: use non-deprecated v8::Uint8Array::kMaxLength nodejs/node#50115 * src: update default V8 platform to override functions with location nodejs/node#51362 * src: add missing TryCatch nodejs/node#51362 * lib,test: handle new Iterator global nodejs/node#51362 * src: use non-deprecated version of CreateSyntheticModule nodejs/node#50115 * src: remove calls to recently deprecated V8 APIs nodejs/node#52996 * src: use new V8 API to define stream accessor nodejs/node#53084 * src: do not use deprecated V8 API nodejs/node#53084 * src: do not use soon-to-be-deprecated V8 API nodejs/node#53174 * src: migrate to new V8 interceptors API nodejs/node#52745 * src: use supported API to get stalled TLA messages nodejs/node#51362 * module: print location of unsettled top-level await in entry points nodejs/node#51999 * test: make snapshot comparison more flexible nodejs/node#54375 * test: do not set concurrency on parallelized runs nodejs/node#52177 * src: move FromNamespacedPath to path.cc nodejs/node#53540 * test: adapt to new V8 trusted memory spaces nodejs/node#50115 * build: add option to enable clang-cl on Windows nodejs/node#52870 * chore: fixup patch indices * chore: add/remove changed files * esm: drop support for import assertions nodejs/node#54890 * build: compile with C++20 support nodejs/node#52838 * deps: update nghttp2 to 1.62.1 nodejs/node#52966 * src: parse inspector profiles with simdjson nodejs/node#51783 * build: add GN build files nodejs/node#47637 * deps,lib,src: add experimental web storage nodejs/node#52435 * build: add missing BoringSSL dep * src: rewrite task runner in c++ nodejs/node#52609 * fixup! build: add GN build files * src: stop using deprecated fields of v8::FastApiCallbackOptions nodejs/node#54077 * fix: shadow variable * build: add back incorrectly removed SetAccessor patch * fixup! fixup! build: add GN build files * crypto: fix integer comparison in crypto for BoringSSL * src,lib: reducing C++ calls of esm legacy main resolve nodejs/node#48325 * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * chore: fixup GN files for previous commit * src: move more crypto code to ncrypto nodejs/node#54320 * Fixup Perfetto ifdef guards * fix: missing electron_natives dep * fix: node_use_node_platform = false * fix: include src/node_snapshot_stub.cc in libnode * 5507047: [import-attributes] Remove support for import assertions https://chromium-review.googlesource.com/c/v8/v8/+/5507047 * fix: restore v8-sandbox.h in filenames.json * fix: re-add original-fs generation logic * fix: ngtcp2 openssl dep * test: try removing NAPI_VERSION undef * chore(deps): bump @types/node * src: move more crypto_dh.cc code to ncrypto nodejs/node#54459 * esm: remove unnecessary toNamespacedPath calls nodejs/node#53656 * buffer: fix out of range for toString nodejs/node#54553 * lib: rewrite AsyncLocalStorage without async_hooks nodejs/node#48528 * module: print amount of load time of a cjs module nodejs/node#52213 * test: skip reproducible snapshot test on 32-bit nodejs/node#53592 * fixup! src: move more crypto_dh.cc code to ncrypto * test: adjust emittedUntil return type * chore: remove redundant wpt streams patch * fixup! chore(deps): bump @types/node * fix: gn executable name on Windows * fix: build on Windows * fix: rename conflicting win32 symbols in //third_party/sqlite On Windows otherwise we get: lld-link: error: duplicate symbol: sqlite3_win32_write_debug >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:47987 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_sleep >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48042 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_is_nt >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48113 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_unicode >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48470 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_unicode_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48486 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48502 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_mbcs_to_utf8_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48518 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48534 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj lld-link: error: duplicate symbol: sqlite3_win32_utf8_to_mbcs_v2 >>> defined at .\..\..\third_party\electron_node\deps\sqlite\sqlite3.c:48550 >>> obj/third_party/electron_node/deps/sqlite/sqlite/sqlite3.obj >>> defined at obj/third_party/sqlite\chromium_sqlite3/sqlite3_shim.obj * docs: remove unnecessary ts-expect-error after types bump * src: move package resolver to c++ nodejs/node#50322 * build: set ASAN detect_container_overflow=0 nodejs/node#55584 * chore: fixup rebase * test: disable failing ASAN test * win: almost fix race detecting ESRCH in uv_kill libuv/libuv#4341
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expect ASan test failures (nodejs/node-v8#268).We need a good way to fix them. #49930 wasn't.
Resolved in 9a3a114