Skip to content

fs: runtime deprecate fs.Stats constructor #52067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2024
Merged

fs: runtime deprecate fs.Stats constructor #52067

merged 1 commit into from
Mar 19, 2024

Conversation

@marco-ippolito
Copy link
Member

@marco-ippolito marco-ippolito commented Mar 13, 2024

moved to runtime deprecated on next semver major, due to being a internal and not supposed to be public. This will help with future refactoring

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Mar 13, 2024
@marco-ippolito marco-ippolito force-pushed the runtime-deprecate-stats branch from 131d146 to 97d350f Compare March 13, 2024 10:11
@marco-ippolito marco-ippolito added deprecations Issues and PRs related to deprecations. semver-major PRs that contain breaking changes and should be released in the next major version. labels Mar 13, 2024
@marco-ippolito marco-ippolito added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 15, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 15, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57753/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 17, 2024

CI: https://ci.nodejs.org/job/node-test-pull-request/57790/

@marco-ippolito marco-ippolito added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Mar 17, 2024
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 19, 2024
@nodejs-github-bot nodejs-github-bot merged commit 8206f6b into main Mar 19, 2024
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 19, 2024

Landed in 8206f6b

@nodejs-github-bot nodejs-github-bot deleted the runtime-deprecate-stats branch March 19, 2024 08:17
@RafaelGSS RafaelGSS mentioned this pull request Apr 12, 2024
Merged
@codebytere
Copy link
Member

codebytere commented Jun 6, 2025 •
edited
Loading

@anonrig @marco-ippolito I missed this when it happened but Electron uses this to handle our asar format - What do you recommend we do now? I think StatFs is now exposed, but it's not really a drop-in from the looks of it.

https://github.com/electron/electron/blob/7601af52002a716f211d24f11c757dd5adb1fe3a/lib/node/asar-fs-wrapper.ts#L122-L143

@codebytere codebytere mentioned this pull request Jun 6, 2025
Open
3 tasks
@codebytere codebytere mentioned this pull request Jun 25, 2025
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamingr benjamingr benjamingr approved these changes

@anonrig anonrig anonrig approved these changes

+1 more reviewer

@mertcanaltin mertcanaltin mertcanaltin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. deprecations Issues and PRs related to deprecations. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marco-ippolito @nodejs-github-bot @codebytere @benjamingr @anonrig @mertcanaltin