stream: bump default highWaterMark #52037

ronag · 2024-03-10T18:23:46Z

NOTEABLE CHANGE: Increase the default highWaterMark for streams. This provides a performance boost across the board at the cost of slightly higher memory usage. Users in memory sensitive environments are encouraged to explicitly set setDefaultHighWaterMark.

This should give a performance boost accross the board.

Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit.

Refs: #46608
Refs: #50120

nodejs-github-bot · 2024-03-10T18:23:51Z

Review requested:

@nodejs/streams

This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: nodejs#52037 Refs: nodejs#46608 Refs: nodejs#50120

nodejs-github-bot · 2024-03-10T18:31:08Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57664/

RafaelGSS

LGTM.

mcollina

lgtm

nodejs-github-bot · 2024-03-11T03:59:17Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57669/

nodejs-github-bot · 2024-03-11T06:29:38Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57671/

nodejs-github-bot · 2024-03-11T07:09:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57672/

ronag · 2024-03-11T07:53:54Z

@Trott Who's a good ping for windows CI failures?

Trott · 2024-03-11T11:28:35Z

@Trott Who's a good ping for windows CI failures?

I don't follow CI stuff closely enough to know, but maybe start with @nodejs/platform-windows. I'd also recommend posting something in #nodejs-core and/or #nodejs-build on the OpenJS Foundation Slack.

nodejs-github-bot · 2024-03-11T13:44:04Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57683/

This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: nodejs#52037 Refs: nodejs#46608 Refs: nodejs#50120

nodejs-github-bot · 2024-03-11T14:38:59Z

CI: https://ci.nodejs.org/job/node-test-pull-request/57687/

nodejs-github-bot · 2024-03-13T19:02:15Z

Landed in 1abff07

This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: nodejs#52037 Refs: nodejs#46608 Refs: nodejs#50120 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Notable Changes: TBD Semver-Major Commits: build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: TBD Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Notable Changes: TBD Semver-Major Commits: build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: #52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Semver-Major Commits: build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: #52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Semver-Major Commits: build: * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: #52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

Semver-Major Commits: build: * (SEMVER-MAJOR) compile with C++20 support on Windows (StefanStojanovic) #52465 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52465 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #52293 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) #50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) #49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) #52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) #51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) #50973 deps: * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52465 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) #52465 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #52465 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52465 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52465 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52465 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52465 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52465 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52465 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52465 * (SEMVER-MAJOR) update V8 to 12.4.254.14 (Michaël Zasso) #52465 * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) #52293 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #52293 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) #52293 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) #52293 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #52293 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #52293 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #52293 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #52293 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #52293 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #52293 * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) #52293 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) #51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) #51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) #51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) #51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) #50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) #50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) #50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) #50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) #50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) #50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) #50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) #50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) #50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) #50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) #50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) #51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) #51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) #50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) #52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) #51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) #50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) #50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) #51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) #51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) #52172 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 127 (Michaël Zasso) #52465 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) #52293 * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) #51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) #51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) #51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) #51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) #50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) #50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) #50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) #52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) #51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) #51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) #50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) #50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) #50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) #52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) #51577 tools: * (SEMVER-MAJOR) update V8 gypfiles for 12.4 (Michaël Zasso) #52465 * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) #51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) #51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) #51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) #50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) #50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) #51360 PR-URL: #52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

As it became the default since Node 22 and benchmarked to be faster: nodejs/node#52037

This should give a performance boost accross the board. Given that the old limit is a decod old and memory capacity has doubled many times since I think it is appropriate to slightly bump the default limit. PR-URL: nodejs#52037 Refs: nodejs#46608 Refs: nodejs#50120 Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Semver-Major Commits: build: * (SEMVER-MAJOR) compile with C++20 support on Windows (StefanStojanovic) nodejs#52465 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) reset embedder string to "-node.0" (Michaël Zasso) nodejs#50115 console: * (SEMVER-MAJOR) treat non-strings as separate argument in console.assert() (Jacob Hummer) nodejs#49722 crypto: * (SEMVER-MAJOR) runtime deprecate hmac constructor (Marco Ippolito) nodejs#52071 * (SEMVER-MAJOR) runtime deprecate Hash constructor (Marco Ippolito) nodejs#51880 * (SEMVER-MAJOR) move createCipher and createDecipher to eol (Marco Ippolito) nodejs#50973 deps: * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) nodejs#52465 * (SEMVER-MAJOR) V8: revert CL 5331688 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#52465 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) update V8 to 12.4.254.14 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) V8: cherry-pick cd10ad7cdbe5 (Joyee Cheung) nodejs#52293 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) nodejs#52293 * (SEMVER-MAJOR) silence internal V8 deprecation warning (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (Stefan Stojanovic) nodejs#52293 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) update V8 to 12.3.219.16 (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) V8: backport c4be0a97f981 (Richard Lau) nodejs#51362 * (SEMVER-MAJOR) V8: cherry-pick f8d5e576b814 (Richard Lau) nodejs#51362 * (SEMVER-MAJOR) patch V8 to support compilation with MSVC (StefanStojanovic) nodejs#51362 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update V8 to 12.2.281.27 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) V8: cherry-pick de611e69ad51 (Keyhan Vakil) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick 0fd478bcdabd (Joyee Cheung) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick 0f9ebbc672c7 (Chengzhong Wu) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick 8f0b94671ddb (Lu Yahan) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick f7d000a7ae7b (Luke Albao) nodejs#50115 * (SEMVER-MAJOR) V8: cherry-pick 25902244ad1a (Joyee Cheung) nodejs#50115 * (SEMVER-MAJOR) patch V8 to avoid duplicated zlib symbol (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) remove usage of a C++20 feature from V8 (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) avoid compilation error with ASan (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) disable V8 concurrent sparkplug compilation (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) silence irrelevant V8 warning (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) always define V8_EXPORT_PRIVATE as no-op (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) update V8 to 11.9.169.7 (Michaël Zasso) nodejs#50115 doc: * (SEMVER-MAJOR) runtime deprecate flag --trace-atomics-wait (marco-ippolito) nodejs#51179 * (SEMVER-MAJOR) bump FreeBSD experimental support to 13.2 (Michaël Zasso) nodejs#51231 * (SEMVER-MAJOR) add migration paths for deprecated utils (Marco Ippolito) nodejs#50488 fs: * (SEMVER-MAJOR) runtime deprecate fs.Stats constructor (Marco Ippolito) nodejs#52067 * (SEMVER-MAJOR) use private fields instead of symbols for `Dir` (Jungku Lee) nodejs#51037 * (SEMVER-MAJOR) make stats date fields lazy (Yagiz Nizipli) nodejs#50908 http: * (SEMVER-MAJOR) preserve raw header duplicates in writeHead after setHeader calls (Tim Perry) nodejs#50394 lib: * (SEMVER-MAJOR) enable WebSocket by default (Aras Abbasi) nodejs#51594 lib,test: * (SEMVER-MAJOR) handle new Iterator global (Michaël Zasso) nodejs#51362 process: * (SEMVER-MAJOR) wait for `'exit'` before printing result (Antoine du Hamel) nodejs#52172 src: * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 127 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 126 (Michaël Zasso) nodejs#52293 * (SEMVER-MAJOR) use supported API to get stalled TLA messages (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update default V8 platform to override functions with location (Etienne Pierre-Doray) nodejs#51362 * (SEMVER-MAJOR) add missing TryCatch (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 124 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) use non-deprecated v8::Uint8Array::kMaxLength (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) adapt to v8::Exception API change (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) use non-deprecated version of CreateSyntheticModule (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) update NODE_MODULE_VERSION to 122 (Michaël Zasso) nodejs#50115 stream: * (SEMVER-MAJOR) bump default highWaterMark (Robert Nagy) nodejs#52037 test: * (SEMVER-MAJOR) mark test-worker-arraybuffer-zerofill as flaky (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) mark some GC-related tests as flaky (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) allow slightly more diff in memory leak test (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) replace always-opt flag with alway-turbofan (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) remove tests that create very large buffers (Michaël Zasso) nodejs#50115 * (SEMVER-MAJOR) adapt to new V8 trusted memory spaces (Michaël Zasso) nodejs#50115 test_runner: * (SEMVER-MAJOR) omit filtered test from output (Colin Ihrig) nodejs#52221 * (SEMVER-MAJOR) improve `--test-name-pattern` to allow matching single test (Michał Drobniak) nodejs#51577 tools: * (SEMVER-MAJOR) update V8 gypfiles for 12.4 (Michaël Zasso) nodejs#52465 * (SEMVER-MAJOR) roughly port v8_abseil to gyp (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.2 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.1 (Michaël Zasso) nodejs#51362 * (SEMVER-MAJOR) update V8 gypfiles for 12.0 (Michaël Zasso) nodejs#51362 trace_events: * (SEMVER-MAJOR) use private fields instead of symbols for `Tracing` (Jungku Lee) nodejs#51180 util: * (SEMVER-MAJOR) runtime deprecate util.log (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isUndefined (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isSymbol (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isString (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isRegExp (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isPrimitive (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isObject (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isNumber (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isNullOrUndefined (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isNull (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isFunction (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isError (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isDate (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecation util.isBuffer (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecation util.isBoolean (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecate util.isArray (Marco Ippolito) nodejs#50488 * (SEMVER-MAJOR) runtime deprecation util._extend (Marco Ippolito) nodejs#50488 v8: * (SEMVER-MAJOR) enable maglev on supported architectures (Keyhan Vakil) nodejs#51360 PR-URL: nodejs#52505 Co-Authored-By: Marco Ippolito <marcoippolito54@gmail.com>

`Readable`'s `highWaterMark` has in fact been 64KiB since nodejs#52037.

`Readable`'s `highWaterMark` has in fact been 64KiB since #52037. PR-URL: #55462 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

`Readable`'s `highWaterMark` has in fact been 64KiB since nodejs#52037. PR-URL: nodejs#55462 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

`Readable`'s `highWaterMark` has in fact been 64KiB since #52037. PR-URL: #55462 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2024

nodejs-github-bot added the needs-ci PRs that need a full CI run. label Mar 10, 2024

ronag force-pushed the bump-highWaterMark-value2 branch from 26cf776 to 3c400fc Compare March 10, 2024 18:24

ronag force-pushed the bump-highWaterMark-value2 branch from 3c400fc to 8f4a308 Compare March 10, 2024 18:25

ronag requested review from RafaelGSS and mcollina March 10, 2024 18:25

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2024

RafaelGSS approved these changes Mar 10, 2024

View reviewed changes

mcollina approved these changes Mar 10, 2024

View reviewed changes

anonrig approved these changes Mar 11, 2024

View reviewed changes

legendecas approved these changes Mar 11, 2024

View reviewed changes

ronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Mar 11, 2024

ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 11, 2024

MoLow approved these changes Mar 11, 2024

View reviewed changes

VoltrexKeyva approved these changes Mar 11, 2024

View reviewed changes

ronag force-pushed the bump-highWaterMark-value2 branch from 8f4a308 to b73ec99 Compare March 11, 2024 14:28

ronag added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2024

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 11, 2024

MoLow approved these changes Mar 13, 2024

View reviewed changes

RafaelGSS added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2024

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 13, 2024

nodejs-github-bot merged commit 1abff07 into nodejs:main Mar 13, 2024
55 checks passed

RafaelGSS mentioned this pull request Apr 12, 2024

2024-04-24, Version 22.0.0 (Current) #52505

Merged

kirillgroshkov added a commit to NaturalCycles/nodejs-lib that referenced this pull request Apr 25, 2024

feat: default non-object stream highWatermark to 64k

fd53324

As it became the default since Node 22 and benchmarked to be faster: nodejs/node#52037

ehmicky mentioned this pull request May 4, 2024

Support Node 22 and drop Node <18.17.0 sindresorhus/merge-streams#41

Merged

jsk95 mentioned this pull request Jun 17, 2024

stream: update doc for new default high water mark #53494

Merged

isker added a commit to isker/node that referenced this pull request Oct 20, 2024

doc: remove outdated remarks about highWaterMark in fs

d116e7d

`Readable`'s `highWaterMark` has in fact been 64KiB since nodejs#52037.

isker mentioned this pull request Oct 20, 2024

doc: remove outdated remarks about highWaterMark in fs #55462

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stream: bump default highWaterMark #52037

stream: bump default highWaterMark #52037

ronag commented Mar 10, 2024 •

edited

Loading

nodejs-github-bot commented Mar 10, 2024 •

edited by ronag

Loading

nodejs-github-bot commented Mar 10, 2024

RafaelGSS left a comment

mcollina left a comment

nodejs-github-bot commented Mar 11, 2024

nodejs-github-bot commented Mar 11, 2024

nodejs-github-bot commented Mar 11, 2024

ronag commented Mar 11, 2024

Trott commented Mar 11, 2024

nodejs-github-bot commented Mar 11, 2024

nodejs-github-bot commented Mar 11, 2024

nodejs-github-bot commented Mar 13, 2024

stream: bump default highWaterMark #52037

stream: bump default highWaterMark #52037

Conversation

ronag commented Mar 10, 2024 • edited Loading

nodejs-github-bot commented Mar 10, 2024 • edited by ronag Loading

nodejs-github-bot commented Mar 10, 2024

RafaelGSS left a comment

Choose a reason for hiding this comment

mcollina left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Mar 11, 2024

nodejs-github-bot commented Mar 11, 2024

nodejs-github-bot commented Mar 11, 2024

ronag commented Mar 11, 2024

Trott commented Mar 11, 2024

nodejs-github-bot commented Mar 11, 2024

nodejs-github-bot commented Mar 11, 2024

nodejs-github-bot commented Mar 13, 2024

ronag commented Mar 10, 2024 •

edited

Loading

nodejs-github-bot commented Mar 10, 2024 •

edited by ronag

Loading