-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Meeting notes 2023-07-10 #102
Merged
anonrig
merged 1 commit into
nodejs:main
from
UlisesGascon:doc/meeting-notes-2023-07-10
Jul 24, 2023
+65
−0
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,65 @@ | ||
# Node.js Performance Team Meeting 2023-07-10 | ||
|
||
## Links | ||
|
||
* **Recording**: https://www.youtube.com/watch?v=jARbOPW2-I4 | ||
* **GitHub Issue**: https://github.com/nodejs/performance/issues/101 | ||
|
||
## Present | ||
|
||
* Performance team: @nodejs/performance | ||
* Yagiz Nizipli: @anonrig | ||
* Ulises Gascon: @ulisesGascon | ||
* Carlos Espa: @Ceres6 | ||
* Rafael Gonzaga: @RafaelGSS | ||
* Ruben Bridgewater: @BridgeAR | ||
|
||
## Agenda | ||
|
||
## Announcements | ||
|
||
*Extracted from **performance-agenda** labeled issues and pull requests from the **nodejs org** prior to the meeting. | ||
|
||
### nodejs/node | ||
|
||
* Improve developer experience for v8 performance related flags [#43407](https://github.com/nodejs/node/issues/43407) | ||
* This is an issue that started in 2022 and is related to the flags that we use to build Node.js | ||
* Let’s keep the item in the agenda for now (visibility) | ||
* Currently this topic is open for community contributions | ||
|
||
### nodejs/performance | ||
|
||
* What's new for the Node.js Performances? - 2023 version [#98](https://github.com/nodejs/performance/issues/98) | ||
* The team can publish news in this issue that are later on collected for a Node.js global activity feed in https://github.com/nodejs/nodejs-news-feeder | ||
* This is a global initiative in the organization | ||
* Removed from the agenda and discussion going offline | ||
* This issue will be pinned in the repository | ||
* Reduce URL initializations in ESM [#92](https://github.com/nodejs/performance/issues/92) | ||
* It was part of a long process from last month (3 PRs to remove unnecessary urls and parsing content) | ||
* Open to contributions to finalize the last part of it | ||
* Improve the performance of package json reader [#91](https://github.com/nodejs/performance/issues/91) | ||
* Node.js is traversing folders (up to two or three levels) looking for package.json, this is slow | ||
* There are two PRs already merged authored by Yagiz related to parsing. | ||
* There is a new benchmark to measure this change (https://github.com/lemire/simdjson_performance_demo) and simdjson library proves that the overhead of reading package json lies in V8 not in Node.js | ||
* There is an independent problem (loading problem) that is related with v8 and not by simdjson | ||
* we can discuss with the v8 team regarding json deserialize/serialize potential improvements. This will require some benchmarking to explain the scenario and the potential improvements | ||
* This is currently open for community contributions | ||
* This improvement is related to startup, require and json manipulation. This will have a great impact in the community | ||
* Fast path for `--no-deprecation` [#90](https://github.com/nodejs/performance/issues/90) | ||
* I think we need a benchmark to show the change of removing deprecations and see the impact of it. The current benchmark shows 1 star confidence, which doesn’t show any improvement. | ||
* Ruben: I don’t think it’s worth the change, because the code is already optimized as well. | ||
* Performance of WHATWG ReadableStream.read() [#82](https://github.com/nodejs/performance/issues/82) | ||
* Expensive `isTraceHTTPEnable` [#81](https://github.com/nodejs/performance/issues/81) | ||
* There was a consensus that the change recommended in this pull request is not worth the performance impact due to adding the extra-overhead and code complexity. | ||
* MakeCallback is very slow [#24](https://github.com/nodejs/performance/issues/24) | ||
|
||
|
||
|
||
## Q&A, Other | ||
|
||
## Upcoming Meetings | ||
|
||
* **Node.js Foundation Calendar**: https://nodejs.org/calendar | ||
|
||
Click `+GoogleCalendar` at the bottom right to add to your own Google calendar. | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we mention about what the discussion is?