This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
quic: allow multiple independent .connect() calls #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explicitly allow calling `.connect()` multiple times to generate separate client sessions on the same socket. This requires making `kMaybeBind` call its callback even if the socket is already bound.
addaleax
commented
Oct 16, 2019
jasnell
approved these changes
Oct 16, 2019
addaleax
added a commit
that referenced
this pull request
Oct 16, 2019
Explicitly allow calling `.connect()` multiple times to generate separate client sessions on the same socket. This requires making `kMaybeBind` call its callback even if the socket is already bound. PR-URL: #176 Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in b2197b5 |
addaleax
added a commit
that referenced
this pull request
Dec 11, 2019
Explicitly allow calling `.connect()` multiple times to generate separate client sessions on the same socket. This requires making `kMaybeBind` call its callback even if the socket is already bound. PR-URL: #176 Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
Explicitly allow calling `.connect()` multiple times to generate separate client sessions on the same socket. This requires making `kMaybeBind` call its callback even if the socket is already bound. PR-URL: nodejs#176 Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
Explicitly allow calling `.connect()` multiple times to generate separate client sessions on the same socket. This requires making `kMaybeBind` call its callback even if the socket is already bound. PR-URL: nodejs#176 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly allow calling
.connect()multiple times to generateseparate client sessions on the same socket. This requires making
kMaybeBindcall its callback even if the socket is already bound.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes