[WIP] benchmark: add basic QUIC benchmark #182

addaleax · 2019-10-16T23:42:03Z

This is currently WIP, because it turns out that the retransmission timing is currently impractical for benchmarking (about 2/3 of the time are just spent waiting for the retransmission timer).

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

jasnell · 2019-10-16T23:48:07Z

Note: I believe @tatsuhiro-t is either planning on adding QUIC support to h2load or has already done so. If not, I definitely think I may open a PR to do so as that would make benchmarking QUIC significantly easier

tatsuhiro-t · 2019-10-17T04:15:46Z

Check out https://github.com/nghttp2/nghttp2/tree/quic#running-h2load-against-http3-server
It is h2load with HTTP/3 support.

jasnell · 2019-10-17T14:36:10Z

Thank you @tatsuhiro-t :-)

PR-URL: #145 Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #150 Reviewed-By: James M Snell <jasnell@gmail.com>

Allow using the handle more directly for I/O in other parts of the codebase. PR-URL: #165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

Co-authored-by: Anna Henningsen <anna@addaleax.net> Co-authored-by: Daniel Bevenius <daniel.bevenius@gmail.com> Co-authored-by: gengjiawen <technicalcute@gmail.com> Co-authored-by: James M Snell <jasnell@gmail.com> Co-authored-by: Lucas Pardue <lucaspardue.24.7@gmail.com> Co-authored-by: Ouyang Yadong <oyydoibh@gmail.com> Co-authored-by: Juan José Arboleda <soyjuanarbol@gmail.com> Co-authored-by: Trivikram Kamat <trivikr.dev@gmail.com>

Ported from tatsuhiro-t/openssl@920a331 PR-URL: #6 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

Fixes: #59 PR-URL: #145 Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #147 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

Introduced in aa99a6a. PR-URL: #149 Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #149 Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #154 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

PR-URL: #153 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

PR-URL: #152 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

Previously, if the expiry timestamp was in the future by less than 1ms, the retransmission timer would not have been scheduled. (This also removes an unused line from the test that this problem made flaky.) PR-URL: #157 Reviewed-By: James M Snell <jasnell@gmail.com>

If we set `preferredAddressPolicy` to `accept` on `QuicClientSession` but receives an invalid preferred address, e.g. we don't define `preferredAddress` on the server, the `QuicClientSession` should still work. Before this PR, the included test will cause segmetation fault. PR-URL: #155 Reviewed-By: James M Snell <jasnell@gmail.com>

It would be better to add a test to ensure that the timeout is greater than the triple PTO if we can get the PTO. PR-URL: #160 Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #159 Reviewed-By: James M Snell <jasnell@gmail.com>

This reverts commit 170c5d0. PR-URL: #138 Reviewed-By: Anna Henningsen <anna@addaleax.net>

This reverts commit ecda77c. PR-URL: #138 Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #138 Reviewed-By: Anna Henningsen <anna@addaleax.net>

This commit will need to be submitted upstream then backed out once it lands and we can update PR-URL: #138 Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #138 Reviewed-By: Anna Henningsen <anna@addaleax.net>

The recent commits have broken the build, tests, and linting. One cctest is not fixed but rather disabled here. PR-URL: #162

After ngtcp2 being updated, `ngtcp2_conn_get_idle_timeout` is renamed as `ngtcp2_conn_get_idle_expiry` which returns `ngtcp2_tstamp` instead of `ngtcp2_duration`. Refs: https://github.com/ngtcp2/ngtcp2/blob/6f40668cdce7db7c043d3a80c07f379841d8c51e/lib/ngtcp2_conn.c#L8604 PR-URL: #166 Reviewed-By: Anna Henningsen <anna@addaleax.net>

Fixes: #75 PR-URL: #150 Reviewed-By: James M Snell <jasnell@gmail.com>

Count the number of times sending stream data is blocked by flow control PR-URL: #213 Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #213 Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #216 Reviewed-By: Anna Henningsen <anna@addaleax.net>

Generate stateless reset token cryptographically Fixes: #62 PR-URL: #215 Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #217 Reviewed-By: Anna Henningsen <anna@addaleax.net>

Currently the doc target fails and this commit attempts for fix these errors. PR-URL: #221 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

PR-URL: #224 Reviewed-By: Anna Henningsen <anna@addaleax.net>

jasnell · 2019-12-13T18:42:20Z

Heads up, this will need to be rebased

addaleax and others added 27 commits December 11, 2019 12:33

src: allow unique_ptrs with custom deleter in memory tracker

ad9d240

PR-URL: #145 Reviewed-By: James M Snell <jasnell@gmail.com>

src: enable StreamPipe for generic StreamBases

fefa469

PR-URL: #150 Reviewed-By: James M Snell <jasnell@gmail.com>

dgram: make UDPWrap more reusable

de9a741

Allow using the handle more directly for I/O in other parts of the codebase. PR-URL: #165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

deps: Add interface required to implement QUIC draft-17

fd87b2f

Ported from tatsuhiro-t/openssl@920a331 PR-URL: #6 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

deps: Remove EOED when SSL_MODE_QUIC_HACK is enabled

b26804b

Ported from tatsuhiro-t/openssl@920a331 PR-URL: #6 Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

quic: support memory tracking

455f965

Fixes: #59 PR-URL: #145 Reviewed-By: James M Snell <jasnell@gmail.com>

doc: fix lint issues in quic.md

acadf02

PR-URL: #147 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

lib: fix typo in stream_base_commons.js

fef9d73

Introduced in aa99a6a. PR-URL: #149 Reviewed-By: James M Snell <jasnell@gmail.com>

test: fix test-process-versions for QUIC

2f697d1

PR-URL: #149 Reviewed-By: James M Snell <jasnell@gmail.com>

quic: test client connect invalid options

4ffd6ab

PR-URL: #154 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

quic: test invalid createSocket

de945c2

PR-URL: #153 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

quic: default options parameter in constructor

74ce4d8

PR-URL: #152 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>

test: add tests for quic idleTimeout

081e1a4

It would be better to add a test to ensure that the timeout is greater than the triple PTO if we can get the PTO. PR-URL: #160 Reviewed-By: James M Snell <jasnell@gmail.com>

test: make test-quic-process-cleanup work with --worker

72d5162

PR-URL: #159 Reviewed-By: James M Snell <jasnell@gmail.com>

Revert "deps: Add interface required to implement QUIC draft-17"

68ffa82

This reverts commit 170c5d0. PR-URL: #138 Reviewed-By: Anna Henningsen <anna@addaleax.net>

Revert "deps: Remove EOED when SSL_MODE_QUIC_HACK is enabled"

d55b970

This reverts commit ecda77c. PR-URL: #138 Reviewed-By: Anna Henningsen <anna@addaleax.net>

deps: Port BoringSSL QUIC APIs

6ea8048

PR-URL: #138 Reviewed-By: Anna Henningsen <anna@addaleax.net>

deps: update OpenSSL config

0088393

PR-URL: #138 Reviewed-By: Anna Henningsen <anna@addaleax.net>

deps: update ngtcp2

0c0e89d

PR-URL: #138 Reviewed-By: Anna Henningsen <anna@addaleax.net>

[Upstream] deps: add handling for x509 and client hello cb

6b58255

This commit will need to be submitted upstream then backed out once it lands and we can update PR-URL: #138 Reviewed-By: Anna Henningsen <anna@addaleax.net>

quic: move to ngtcp2_crypto

e66545a

PR-URL: #138 Reviewed-By: Anna Henningsen <anna@addaleax.net>

quic: fix build and tests

8028d09

The recent commits have broken the build, tests, and linting. One cctest is not fixed but rather disabled here. PR-URL: #162

quic: implement sendFD() support

0785819

Fixes: #75 PR-URL: #150 Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell and others added 13 commits December 11, 2019 13:59

quic: add blockCount statistic

9509ec0

Count the number of times sending stream data is blocked by flow control PR-URL: #213 Reviewed-By: Anna Henningsen <anna@addaleax.net>

quic: add max offset statistic, expose stream stats to js

9772656

PR-URL: #213 Reviewed-By: Anna Henningsen <anna@addaleax.net>

quic: use constants for QuicSocket stats

ed6a4d0

PR-URL: #213 Reviewed-By: Anna Henningsen <anna@addaleax.net>

quic: fix lint issues

048cdcb

PR-URL: #213 Reviewed-By: Anna Henningsen <anna@addaleax.net>

quic: additional doc updates

a025f7f

PR-URL: #213 Reviewed-By: Anna Henningsen <anna@addaleax.net>

quic: use const refs

5693be4

PR-URL: #216 Reviewed-By: Anna Henningsen <anna@addaleax.net>

quic: more idiomatic operators

6045212

PR-URL: #216 Reviewed-By: Anna Henningsen <anna@addaleax.net>

quic: stateless reset generate strategy

42cc8ac

Generate stateless reset token cryptographically Fixes: #62 PR-URL: #215 Reviewed-By: Anna Henningsen <anna@addaleax.net>

quic: simplify and condense

ef1fb08

PR-URL: #217 Reviewed-By: Anna Henningsen <anna@addaleax.net>

quic: minor cleanups

fbafe8d

PR-URL: #217 Reviewed-By: Anna Henningsen <anna@addaleax.net>

quic: get name and value as std::string option

fe26977

PR-URL: #217 Reviewed-By: Anna Henningsen <anna@addaleax.net>

doc,tools: fix make doc target for quic.md

a8ac638

Currently the doc target fails and this commit attempts for fix these errors. PR-URL: #221 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

src: fix lint-cpp issues

3bd75b5

PR-URL: #224 Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax force-pushed the master branch from b3b9c0e to 3bd75b5 Compare December 11, 2019 19:03

[WIP] benchmark: add basic QUIC benchmark

e86a500

addaleax force-pushed the benchmark branch from a14d13b to e86a500 Compare December 11, 2019 19:07

jasnell force-pushed the master branch from cf320b5 to 04c4af9 Compare December 13, 2019 18:23

jasnell force-pushed the master branch from 4686b28 to 7ba53ab Compare February 3, 2020 19:28

jasnell force-pushed the master branch 3 times, most recently from 76d2afc to b69367d Compare February 13, 2020 19:39

jasnell force-pushed the master branch 4 times, most recently from 928c50e to 08796cc Compare March 17, 2020 16:23

jasnell force-pushed the master branch 2 times, most recently from 78e9941 to cee2e5d Compare March 24, 2020 01:14

jasnell force-pushed the master branch from cee2e5d to da5f169 Compare April 7, 2020 20:37

jasnell force-pushed the master branch from e782ca4 to bc1b2c0 Compare May 7, 2020 23:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] benchmark: add basic QUIC benchmark #182

[WIP] benchmark: add basic QUIC benchmark #182

addaleax commented Oct 16, 2019

jasnell commented Oct 16, 2019

tatsuhiro-t commented Oct 17, 2019

jasnell commented Oct 17, 2019

jasnell commented Dec 13, 2019

[WIP] benchmark: add basic QUIC benchmark #182

Are you sure you want to change the base?

[WIP] benchmark: add basic QUIC benchmark #182

Conversation

addaleax commented Oct 16, 2019

Checklist

jasnell commented Oct 16, 2019

tatsuhiro-t commented Oct 17, 2019

jasnell commented Oct 17, 2019

jasnell commented Dec 13, 2019