Skip to content
This repository has been archived by the owner on Aug 11, 2020. It is now read-only.

quic: more test fixups #335

Closed
wants to merge 16 commits into from
Closed

quic: more test fixups #335

wants to merge 16 commits into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Feb 7, 2020

No description provided.

@jasnell jasnell requested a review from addaleax February 8, 2020 00:43
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, basically only have the same two comments for a number of files :) The .then(common.mustCall()) is something we should definitely have.

test/parallel/test-quic-client-empty-preferred-address.js Outdated Show resolved Hide resolved
test/parallel/test-quic-idle-timeout.js Outdated Show resolved Hide resolved
test/parallel/test-quic-idle-timeout.js Outdated Show resolved Hide resolved
test/parallel/test-quic-idle-timeout.js Outdated Show resolved Hide resolved
test/parallel/test-quic-idle-timeout.js Outdated Show resolved Hide resolved
test/parallel/test-quic-ipv6only.js Outdated Show resolved Hide resolved
test/parallel/test-quic-keylog.js Outdated Show resolved Hide resolved
test/parallel/test-quic-keylog.js Outdated Show resolved Hide resolved
test/parallel/test-quic-quicsession-openstream-pending.js Outdated Show resolved Hide resolved
test/parallel/test-quic-quicsession-openstream-pending.js Outdated Show resolved Hide resolved
Co-Authored-By: Anna Henningsen <github@addaleax.net>
@jasnell jasnell requested a review from addaleax February 10, 2020 14:22
jasnell added a commit that referenced this pull request Feb 10, 2020
PR-URL: #335
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell
Copy link
Member Author

jasnell commented Feb 10, 2020

Landed

@jasnell jasnell closed this Feb 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants