-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add microsoft edge to testing #194
Conversation
cool! |
There are couple of failures with
Something is wrong? Maybe it needs a timeout for the tunnel. Unrelated, why travis data do not show up here? |
travis data doesn't show up here because there is no way to turn it on for this repo but not for all repos in the org, I don't know about the timeout might be a bug in zuul |
@calvinmetcalf are you sure about travis? was it discussed? |
yes I discussed it with @Fishrock123 on irc |
Wait, what about Travis and IRC? |
@Fishrock123 'travis data doesn't show up here because there is no way to turn it on for this repo but not for all repos in the org ...' |
oh right. We should use @phillipj's bot that the website uses: https://github.com/nodejs-github-bot/github-bot |
what is that ? On Tue, Apr 5, 2016 at 2:45 PM Jeremiah Senkpiel notifications@github.com
|
The website WG uses that bot to post travis statuses because they have the same problem. |
@calvinmetcalf nodejs/nodejs.org#355 (comment) It should work out of the box, as this repo is in the same weird Travis state as nodejs.org. Meaning Travis picks up changes, but the inline integration with PR's doesn't work because of the 3rd party permission issue you mentioned earlier. https://travis-ci.org/nodejs/readable-stream I'll send you the webhook URL needed on IRC to make nodejs-github-bot add comments on every created PR about the Travis build status. |
ok thanks On Tue, Apr 5, 2016 at 2:55 PM Phillip Johnsen notifications@github.com
|
ok repushed to see if that was an intermittent failure |
this is green |
#193