Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add microsoft edge to testing #194

Merged
merged 1 commit into from
Apr 8, 2016
Merged

add microsoft edge to testing #194

merged 1 commit into from
Apr 8, 2016

Conversation

calvinmetcalf
Copy link
Contributor

@yoshuawuyts
Copy link

cool!

@mcollina
Copy link
Member

mcollina commented Apr 5, 2016

There are couple of failures with

Error: connection refused: localtunnel.me:35059 (check your firewall settings)

Something is wrong? Maybe it needs a timeout for the tunnel.

Unrelated, why travis data do not show up here?

@calvinmetcalf
Copy link
Contributor Author

travis data doesn't show up here because there is no way to turn it on for this repo but not for all repos in the org, I don't know about the timeout might be a bug in zuul

@mcollina
Copy link
Member

mcollina commented Apr 5, 2016

@calvinmetcalf are you sure about travis? was it discussed?

@calvinmetcalf
Copy link
Contributor Author

yes I discussed it with @Fishrock123 on irc

@Fishrock123
Copy link

Wait, what about Travis and IRC?

@calvinmetcalf
Copy link
Contributor Author

@Fishrock123 'travis data doesn't show up here because there is no way to turn it on for this repo but not for all repos in the org ...'

@Fishrock123
Copy link

oh right.

We should use @phillipj's bot that the website uses: https://github.com/nodejs-github-bot/github-bot

@calvinmetcalf
Copy link
Contributor Author

what is that ?

On Tue, Apr 5, 2016 at 2:45 PM Jeremiah Senkpiel notifications@github.com
wrote:

oh right.

We should use @phillipj https://github.com/phillipj's bot that the
website uses: https://github.com/nodejs-github-bot/github-bot


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#194 (comment)

@Fishrock123
Copy link

The website WG uses that bot to post travis statuses because they have the same problem.

@phillipj
Copy link
Member

phillipj commented Apr 5, 2016

@calvinmetcalf nodejs/nodejs.org#355 (comment)

It should work out of the box, as this repo is in the same weird Travis state as nodejs.org. Meaning Travis picks up changes, but the inline integration with PR's doesn't work because of the 3rd party permission issue you mentioned earlier.

https://travis-ci.org/nodejs/readable-stream

I'll send you the webhook URL needed on IRC to make nodejs-github-bot add comments on every created PR about the Travis build status.

@calvinmetcalf
Copy link
Contributor Author

ok thanks

On Tue, Apr 5, 2016 at 2:55 PM Phillip Johnsen notifications@github.com
wrote:

@calvinmetcalf https://github.com/calvinmetcalf nodejs/nodejs.org#355
(comment)
nodejs/nodejs.org#355 (comment)

It should work out of the box, as this repo is in the same weird Travis
state as nodejs.org. Meaning Travis picks up changes, but the inline
integration with PR's doesn't work because of the 3rd party permission
issue you mentioned earlier.

https://travis-ci.org/nodejs/readable-stream

I'll send you the webhook URL needed on IRC to make nodejs-github-bot add
comments on every created PR about the Travis build status.


You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub
#194 (comment)

@nodejs-github-bot
Copy link
Collaborator

Travis build failed 👎

@calvinmetcalf
Copy link
Contributor Author

ok repushed to see if that was an intermittent failure

@calvinmetcalf
Copy link
Contributor Author

this is green

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants