revert bundled dependencies #243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvinmetcalf
force-pushed
the
remove-bundled-deps
branch
from
f47d293 to
fe22967
Compare
|
Just to clarify, yarn and others should implement bundleDependencies. |
|
the issue isn't with yarn not handling bundled deps actually, its with running yarn, node is looking at the old location so it is likely an upgrading issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
looks like there are some issues with globals or something, basically this is breaking yarn yarnpkg/yarn#1774 so I plan on publishing this as 2.2.1 pretty shortly