-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated to node v7.10.0. #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blah blah test churn looks good assuming the tests pass
@calvinmetcalf there was a verify high number of breakages due to npm and some things that were not transpiled. |
@calvinmetcalf CI is badly broken :( https://travis-ci.org/nodejs/readable-stream/jobs/237500260 |
ah looks like they stoped supporting 0.10? |
@zkat can you have a look here? it used to work :(. |
@mcollina we do not support, at all, any versions of node older than node@4. Only node versions still in maintenance are targeted, and we've started intentionally breaking compatibility now. |
@zkat You mean that |
@mcollina I guess lts and 3 would probably still work, but this stuff isn't really supposed to run on |
@zkat we are now using npm@2 and npm@latest-3 in the unsupported versions of Node. Things are passing again now :). |
@calvinmetcalf I disabled the new |
ok what was the issue with unpipe events ? |
This is the relative PR: nodejs/node#11876. I do not know why it does not pass on node 0.8. |
ok looks like the test may have been wonky? I don't know lgtm |
cc @nodejs/streams