Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Node v10.17.0 #420

Merged
merged 8 commits into from
Jan 17, 2020
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test passing on browser
mcollina committed Oct 25, 2019

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
commit 6953e52b46e1ae10468cc41b70e3b5ed97dec6b4
8 changes: 8 additions & 0 deletions build/test-replacements.js
Original file line number Diff line number Diff line change
@@ -109,6 +109,14 @@ module.exports['common.js'] = [
, deepStrictEqual
, catchES7
, catchES7OpenClose
, [
/require\('module'\)\.builtinModules\.includes\('worker_threads'\)/,
'false'
]
, [
/process.argv.length === 2/,
'false'
]
, [
/^( for \(var x in global\) \{|function leakedGlobals\(\) \{)$/m
, ' /*<replacement>*/\n'
4 changes: 2 additions & 2 deletions test/common/index.js
Original file line number Diff line number Diff line change
@@ -96,7 +96,7 @@ var noop = function noop() {};
var hasCrypto = true;

var isMainThread = function () {
if (require('module').builtinModules.includes('worker_threads')) {
if (false) {
return require('worker_threads').isMainThread;
} // Worker module not enabled → only a single main thread exists.

@@ -106,7 +106,7 @@ var isMainThread = function () {
// `worker_threads`) and child processes.


if (process.argv.length === 2 && isMainThread && module.parent && require('cluster').isMaster) {
if (false && isMainThread && module.parent && require('cluster').isMaster) {
// The copyright notice is relatively big and the flags could come afterwards.
var bytesToRead = 1500;
var buffer = Buffer.allocUnsafe(bytesToRead);