You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Prs such as #57 are automatically generated by the Update Links action. That is the action that makes sure links such as nodejs.org/docs/latest/ point to the absolute latest documentation available.
As of now, the action can either be triggered manually by someone with write access to the repository or by waiting until midnight. This poses a problem since when a release is promoted it needs to be available as immediately as possible. Releasers don't have write access to this repo, and so they can't manually trigger the action. Furthermore, only members of @nodejs/web-infra can approve and merge the pr. Then, someone with write access needs to trigger the Deploy action to get the updated redirects into prod.
This of course isn't great. nodejs/node#50710 is partially fixing this problem by triggering the Update Links action whenever there's a new Github release of node, however there still is the pr that needs to be approved and merged by someone on the @nodejs/web-infra team and it still needs to be manually deployed to prod.
Solution:
Changing the Update Links action to write directly into the main branch, skipping the entire pr step
Trigger the Deploy action once Update Links has finished executing, and making it so it deploys to prod.
The text was updated successfully, but these errors were encountered:
Prs such as #57 are automatically generated by the
Update Links
action. That is the action that makes sure links such asnodejs.org/docs/latest/
point to the absolute latest documentation available.As of now, the action can either be triggered manually by someone with write access to the repository or by waiting until midnight. This poses a problem since when a release is promoted it needs to be available as immediately as possible. Releasers don't have write access to this repo, and so they can't manually trigger the action. Furthermore, only members of @nodejs/web-infra can approve and merge the pr. Then, someone with write access needs to trigger the
Deploy
action to get the updated redirects into prod.This of course isn't great. nodejs/node#50710 is partially fixing this problem by triggering the
Update Links
action whenever there's a new Github release of node, however there still is the pr that needs to be approved and merged by someone on the @nodejs/web-infra team and it still needs to be manually deployed to prod.Solution:
Update Links
action to write directly into themain
branch, skipping the entire pr stepDeploy
action onceUpdate Links
has finished executing, and making it so it deploys to prod.The text was updated successfully, but these errors were encountered: