Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically merge & deploy prs for updating redirect links #66

Closed
Tracked by #74
flakey5 opened this issue Nov 14, 2023 · 0 comments · Fixed by #85
Closed
Tracked by #74

Automatically merge & deploy prs for updating redirect links #66

flakey5 opened this issue Nov 14, 2023 · 0 comments · Fixed by #85

Comments

@flakey5
Copy link
Member

flakey5 commented Nov 14, 2023

Prs such as #57 are automatically generated by the Update Links action. That is the action that makes sure links such as nodejs.org/docs/latest/ point to the absolute latest documentation available.

As of now, the action can either be triggered manually by someone with write access to the repository or by waiting until midnight. This poses a problem since when a release is promoted it needs to be available as immediately as possible. Releasers don't have write access to this repo, and so they can't manually trigger the action. Furthermore, only members of @nodejs/web-infra can approve and merge the pr. Then, someone with write access needs to trigger the Deploy action to get the updated redirects into prod.

This of course isn't great. nodejs/node#50710 is partially fixing this problem by triggering the Update Links action whenever there's a new Github release of node, however there still is the pr that needs to be approved and merged by someone on the @nodejs/web-infra team and it still needs to be manually deployed to prod.

Solution:

  • Changing the Update Links action to write directly into the main branch, skipping the entire pr step
  • Trigger the Deploy action once Update Links has finished executing, and making it so it deploys to prod.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant