-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI Reliability 2023-09-27 #676
Comments
This was referenced Sep 27, 2023
joyeecheung
added a commit
to nodejs/node
that referenced
this issue
Sep 29, 2023
Previously when checking the initial timing we did a lot of checks after accessing and copying timing.duration and before we check that timing.duration is roughly the same as performance.now(), which can lead to flakes if the overhead of the checking is big enough. Update the test to check timing.duration against performance.now() as soon as possible when it's copied instead of computed. :# PR-URL: #49892 Refs: nodejs/reliability#676 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
alexfernandez
pushed a commit
to alexfernandez/node
that referenced
this issue
Nov 1, 2023
Previously when checking the initial timing we did a lot of checks after accessing and copying timing.duration and before we check that timing.duration is roughly the same as performance.now(), which can lead to flakes if the overhead of the checking is big enough. Update the test to check timing.duration against performance.now() as soon as possible when it's copied instead of computed. :# PR-URL: nodejs#49892 Refs: nodejs/reliability#676 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
targos
pushed a commit
to nodejs/node
that referenced
this issue
Nov 11, 2023
Previously when checking the initial timing we did a lot of checks after accessing and copying timing.duration and before we check that timing.duration is roughly the same as performance.now(), which can lead to flakes if the overhead of the checking is big enough. Update the test to check timing.duration against performance.now() as soon as possible when it's copied instead of computed. :# PR-URL: #49892 Refs: nodejs/reliability#676 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
debadree25
pushed a commit
to debadree25/node
that referenced
this issue
Apr 15, 2024
Previously when checking the initial timing we did a lot of checks after accessing and copying timing.duration and before we check that timing.duration is roughly the same as performance.now(), which can lead to flakes if the overhead of the checking is big enough. Update the test to check timing.duration against performance.now() as soon as possible when it's copied instead of computed. :# PR-URL: nodejs#49892 Refs: nodejs/reliability#676 Reviewed-By: Chemi Atlow <chemi@atlow.co.il> Reviewed-By: Richard Lau <rlau@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
None yet
0 participants
Failures in node-test-pull-request/54170 to node-test-pull-request/54263 that failed 2 or more PRs
(Generated with
ncu-ci walk pr --stats=true --markdown /home/runner/work/reliability/reliability/results.md
)JSTest Failure
parallel/test-inspector-scriptparsed-context
Example
parallel/test-tls-socket-close
Example
sequential/test-http-regr-gh-2928
Example
sequential/test-net-connect-econnrefused
Example
sequential/test-perf-hooks
Example
parallel/test-cluster-fork-stdio
Example
parallel/test-fs-rmdir-recursive
Example
parallel/test-fs-write-stream-eagain
Example
parallel/test-http-server-request-timeouts-mixed
Example
parallel/test-inspector-console
Example
parallel/test-inspector-debug-end
Example
parallel/test-inspector-esm
Example
parallel/test-inspector-multisession-ws
Example
parallel/test-inspector-stop-profile-after-done
Example
parallel/test-runner-output
Example
parallel/test-tick-processor-arguments
Example
parallel/test-worker-memory
Example
pummel/test-crypto-timing-safe-equal-benchmarks
Example
sequential/test-http-keepalive-maxsockets
Example
Jenkins Failure
Build timed out (after 60 minutes). Marking the build as failed.
Example
CCTest Failure
Git Failure
Build Failure
ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error?
Example
Progress
parallel/test-inspector-scriptparsed-context
(3)parallel/test-tls-socket-close
(3)sequential/test-http-regr-gh-2928
(3)sequential/test-net-connect-econnrefused
(3)sequential/test-perf-hooks
(3)parallel/test-cluster-fork-stdio
(2)parallel/test-fs-rmdir-recursive
(2)parallel/test-fs-write-stream-eagain
(2)parallel/test-http-server-request-timeouts-mixed
(2)parallel/test-inspector-console
(2)parallel/test-inspector-debug-end
(2)parallel/test-inspector-esm
(2)parallel/test-inspector-multisession-ws
(2)parallel/test-inspector-stop-profile-after-done
(2)parallel/test-runner-output
(2)parallel/test-tick-processor-arguments
(2)parallel/test-worker-memory
(2)pummel/test-crypto-timing-safe-equal-benchmarks
(2)sequential/test-http-keepalive-maxsockets
(2)Build timed out (after 60 minutes). Marking the build as failed.
(14)ERROR: Step ?Publish JUnit test result report? failed: No test report files were found. Configuration error?
(3)The text was updated successfully, but these errors were encountered: