Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0.0 checks are broken? #219

Closed
aduh95 opened this issue Aug 16, 2021 · 3 comments
Closed

3.0.0 checks are broken? #219

aduh95 opened this issue Aug 16, 2021 · 3 comments

Comments

@aduh95
Copy link
Contributor

aduh95 commented Aug 16, 2021

Does the fact that this succeeded means the unordered links check isn't working in 3.0.0? @nschonni

Originally posted by @Trott in nodejs/TSC#1072 (comment)

I've also noticed nodejs/node#39754 (comment), where a user is using a malformed version string, which nodejs-yaml-comments should be picking up, but the GH Action is green still.
@nschonni
Copy link
Member

I guess it might be time for a few unit tests in addition to the integration test on the full repo we have now

@Trott
Copy link
Member

Trott commented Aug 21, 2021

I've got the fix coming momentarily.

Trott added a commit to Trott/remark-preset-lint-node that referenced this issue Aug 21, 2021
@Trott
fix: detect lint errors
db0ddea 
The previous version had a bug where it...uh...didn't actually lint
anything. We've added a test now to at least make sure errors are
reported.

Fixes: nodejs#219
@Trott
Copy link
Member

Trott commented Aug 21, 2021

Fix is in #249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Trott @nschonni @aduh95