Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CVE-2018-14732 webpack-dev-server #460

Closed
rschultheis opened this issue Dec 21, 2018 · 2 comments
Closed

CVE-2018-14732 webpack-dev-server #460

rschultheis opened this issue Dec 21, 2018 · 2 comments

Comments

@rschultheis
Copy link
Contributor

👋

I've been looking at this CVE-2018-14732, and also the corresponding NPM Advisory: https://www.npmjs.com/advisories/725

It seems like this should be added into this repo? I'd be happy to submit a PR if ya'll agree. Not sure I understand all the policies of this repo, is it ideally supposed to contain all the public NPM CVEs?

Also, there is a problem with the CVE Data and the Advisory in NPM too. This comment outlines the problem. The CVE/NPM Advisory claim this is fixed in web pack-dev-server 3.1.6, but it is not. The fix is in an un-merged branch. All that is needed for a fix is a PR and a release, but not clear if the maintainers are going to do that. I'm looking for any help to either get the CVE corrected and/or get a patch released.

webpack-dev-server is widely used, though in a development context. The exploitability of this is not clear to me. Can someone backup the maintainers claim that the exploitability of this is low?

Much thanks 🙇
@rschultheis rschultheis mentioned this issue Dec 21, 2018
Merged
@rschultheis
Copy link
Contributor Author

The maintainer just released 3.1.11 with a fix for this, and thus I opened this PR to add this CVE into this dataset: #461

@lirantal
Copy link
Member

Thanks @rschultheis for letting us know.
We don't aim to pro-actively collect and cover all the security advisories across the npm ecosystem that aren't reported directly to us. That said, we'd be happy accept any PRs to the vulnerability database to further enhance it even if these hadn't been reported to our HackerOne program.

I appreciate you jumping on the repo and sharing and PRing this.
Thank you! ❤️

marado added a commit to marado/simple-tetris that referenced this issue Apr 22, 2019
@marado
update webpack-dev-server dependency version
efbce22 
webpack-dev-server 3.1.10 has a security vulnerability[1] that was
fixed on 3.1.11. That version is retrocompatible, so this patch
simply bumps the dependency.

[1] nodejs/security-wg#460
@marado marado mentioned this issue Apr 22, 2019
Merged
robertrypula pushed a commit to robertrypula/simple-tetris that referenced this issue Apr 24, 2019
@marado @robertrypula
update webpack-dev-server dependency version (#4)
dbad807 
webpack-dev-server 3.1.10 has a security vulnerability[1] that was
fixed on 3.1.11. That version is retrocompatible, so this patch
simply bumps the dependency.

[1] nodejs/security-wg#460
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sam-github @lirantal @rschultheis