Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Node.js Scorecard #929

Closed
4 tasks done
RafaelGSS opened this issue Mar 23, 2023 · 10 comments
Closed
4 tasks done

Improve Node.js Scorecard #929

RafaelGSS opened this issue Mar 23, 2023 · 10 comments

Comments

@RafaelGSS
Copy link
Member

RafaelGSS commented Mar 23, 2023

Reference: https://github.com/nodejs/security-wg/blob/main/tools/ossf_scorecard/report.md

We need to:

Note: we can use the StepSecurity for an automated PR.

@RafaelGSS
Copy link
Member Author

Actually, there's already a PR for pinned actions nodejs/node#46820

@mateonunez
Copy link
Contributor

Hey @RafaelGSS, I would love to deep into this. Just a couple of questions:

  • The workflow should be set only in the main branch at push or we want to include also other stable branches ?
  • There's a specific scheduled time to run the workflow?

@RafaelGSS
Copy link
Member Author

The workflow should be set only in the main branch at push or we want to include also other stable branches ?

main branch

There's a specific scheduled time to run the workflow?

You can use the same as the one we use for this repo.

@mateonunez
Copy link
Contributor

I created this PR to increase the scorecard score by adding the missing dependencies: nodejs/node#47346

I'm sure that by merging this we can get very close to score 10 on the topic "Pinned-Dependencies".

@RafaelGSS
Copy link
Member Author

UPDATE from #945

Node.js score: 7.6 - 2023-04-08

@RafaelGSS
Copy link
Member Author

UPDATE from #961

Repository Commit Score Date Difference Report Link StepSecurity Link
nodejs/node 2ac5e98 7.3 2023-04-26T08:57:49Z -0.3 Full Report Fix it

@UlisesGascon
Copy link
Member

UPDATE from #981

Repository Commit Score Date Difference Report Link StepSecurity Link
nodejs/node 12a93ce 7.3 2023-05-10T08:02:33Z 0 Full Report Fix it

@RafaelGSS
Copy link
Member Author

As discussed in #1042, we can pin the node-core-utils in a package.json to run the command: https://github.com/nodejs/node/blob/main/tools/actions/start-ci.sh.

See: https://kooltheba.github.io/openssf-scorecard-api-visualizer/#/projects/github.com/nodejs/node/compare/2ac5e9889aba461f5a54d320973d2574980d206b/b5e16adb1d155759e7db405eead5a43cd425785d (pinned dependencies)

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2023

This issue is stale because it has been open many days with no activity. It will be closed soon unless the stale label is removed or a comment is made.

@github-actions github-actions bot added the stale label Oct 5, 2023
@RafaelGSS RafaelGSS removed the stale label Oct 8, 2023
@RafaelGSS
Copy link
Member Author

I'm closing it since we've achieved our goal of improving the scorecard and now, we're monitoring the score on each meeting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants