Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add publishing credentials to repo secrets #56

Closed
MoLow opened this issue Apr 11, 2024 · 5 comments · Fixed by #57
Closed

add publishing credentials to repo secrets #56

MoLow opened this issue Apr 11, 2024 · 5 comments · Fixed by #57
Assignees

Comments

@MoLow
Copy link
Member

MoLow commented Apr 11, 2024

since this repo is under the node.js org - there should be a way for @nodejs/build to publish a new version.
that can be done either by adding a repository secret and a GitHub actions flow to publish a version or by adding credentials to https://github.com/nodejs-private/secrets

@MoLow
Copy link
Member Author

MoLow commented May 16, 2024

added to the tsc-agenda so we can discuss - this and #54 seem stuck with only a single individual having credentials to release this.
@mhdawson - I am not sure if this repo is part of the automation to be added to TSC meetings, so lets make sure it is added manually if not

@mhdawson
Copy link
Member

@MoLow the tool looks across the org so as long as it is under nodejs.org it should appear on the agenda.

@legendecas
Copy link
Member

legendecas commented May 30, 2024

Using OIDC provided by GitHub Action, we don't have to save credentials or secrets to publish pypi packages, like how gyp-next is published. As a nodejs account is created in nodejs/admin#863, I believe this can move forward and untag tsc-agenda ?

@benjamingr
Copy link
Member

@MoLow should this be discussed or is @legendecas 's suggestion sufficient?

@MoLow MoLow removed the tsc-agenda label Jun 3, 2024
@MoLow
Copy link
Member Author

MoLow commented Jun 3, 2024

I am planning on implementing the suggestion. until I verify it - I removed the issue from the agenda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants