fix missing stack property #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardlau
reviewed
Mar 23, 2024
MoLow
approved these changes
Mar 26, 2024
|
@MoLow @richardlau How should we fix the failing tests? Which is correct -- the actual vs. the expected? |
|
Not sure. CC @aduh95 |
|
i have no idea, the tests pass on my machine. It looks a rounding error 🤔 |
MoLow
approved these changes
Mar 26, 2024
|
OK, it looks like it's a difference between Python 3.9 (that I was using locally) and Python 3.12 (that the CI was using). Generating the fixtures with Python 3.12 seems to solve the issue. |
|
Great! The only remaining unanswered question is #54 (comment) |
richardlau
approved these changes
Apr 10, 2024
|
@cclauss can you release this to Pypi? |
|
Ping @nodejs/python, any chance we could have this patch in a release so the CI starts using it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: nodejs/node#52189 (comment)