fix: webidl.brandcheck non strict should throw

nodejs · Feb 1, 2024 · 0b8d8e3 · 0b8d8e3
1 parent 0808a72
commit 0b8d8e3
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/lib/fetch/webidl.js b/lib/fetch/webidl.js
@@ -34,10 +34,14 @@ webidl.errors.invalidArgument = function (context) {
 
 // https://webidl.spec.whatwg.org/#implements
 webidl.brandCheck = function (V, I, opts = undefined) {
-  if (opts?.strict !== false && !(V instanceof I)) {
-    throw new TypeError('Illegal invocation')
+  if (opts?.strict !== false) {
+    if (!(V instanceof I)) {
+      throw new TypeError('Illegal invocation')
+    }
   } else {
-    return V?.[Symbol.toStringTag] === I.prototype[Symbol.toStringTag]
+    if (V?.[Symbol.toStringTag] === I.prototype[Symbol.toStringTag]) {
+      throw new TypeError('Illegal invocation')
+    }
   }
 }