Apply suggestions from code review

Co-authored-by: Robert Nagy <ronagy@icloud.com>
nodejs · Nov 18, 2024 · 6ca427c · 6ca427c
1 parent 4c3dd04
commit 6ca427c
Showing 1 changed file with 6 additions and 6 deletions.
diff --git a/lib/interceptor/cache.js b/lib/interceptor/cache.js
@@ -14,18 +14,18 @@ const AGE_HEADER = Buffer.from('age')
  * @param {import('../../types/dispatcher.d.ts').default.DispatchHandlers} handler
  */
 function sendGatewayTimeout (handler) {
-  const ac = new AbortController()
-  const signal = ac.signal
-
+  let aborted = false
   try {
     if (typeof handler.onConnect === 'function') {
-      handler.onConnect(ac.abort)
-      signal.throwIfAborted()
+      handler.onConnect(() => {
+        aborted = true
+      })
+      if (aborted) return
     }
 
     if (typeof handler.onHeaders === 'function') {
       handler.onHeaders(504, [], () => {}, 'Gateway Timeout')
-      signal.throwIfAborted()
+      if (aborted) return
     }
 
     if (typeof handler.onComplete === 'function') {