set websocket readyState on fail (#3507)

Fixes #3506 set websocket readyState on fail Fixes #3506
nodejs · Aug 25, 2024 · e96178f · e96178f
1 parent 9d57401
commit e96178f
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 0 deletions.
diff --git a/lib/web/websocket/websocket.js b/lib/web/websocket/websocket.js
@@ -522,6 +522,8 @@ class WebSocket extends EventTarget {
       this.#handler.socket.destroy()
     }
 
+    this.#handler.readyState = states.CLOSED
+
     if (reason) {
       // TODO: process.nextTick
       fireEvent('error', this, (type, init) => new ErrorEvent(type, init), {

diff --git a/test/websocket/issue-3506.js b/test/websocket/issue-3506.js
@@ -0,0 +1,18 @@
+'use strict'
+
+const { test } = require('node:test')
+const { WebSocket } = require('../..')
+const { tspl } = require('@matteo.collina/tspl')
+
+test('readyState is set on fail', async (t) => {
+  const { deepStrictEqual, completed } = tspl(t, { plan: 1 })
+  const ws = new WebSocket('ws://localhost:1')
+
+  t.after(() => ws.close())
+
+  ws.addEventListener('error', () => {
+    deepStrictEqual(ws.readyState, WebSocket.CLOSED)
+  })
+
+  await completed
+})