refactor: maxEntryCount

nodejs · Nov 13, 2024 · fff0b2c · fff0b2c
1 parent 28b10fa
commit fff0b2c
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/lib/cache/memory-cache-store.js b/lib/cache/memory-cache-store.js
@@ -13,7 +13,7 @@ const { Writable } = require('node:stream')
  * }} MemoryStoreValue
  */
 class MemoryCacheStore {
-  #maxEntries = Infinity
+  #maxCount = Infinity
 
   #maxEntrySize = Infinity
 
@@ -33,15 +33,15 @@ class MemoryCacheStore {
         throw new TypeError('MemoryCacheStore options must be an object')
       }
 
-      if (opts.maxEntries !== undefined) {
+      if (opts.maxCount !== undefined) {
         if (
-          typeof opts.maxEntries !== 'number' ||
-          !Number.isInteger(opts.maxEntries) ||
-          opts.maxEntries < 0
+          typeof opts.maxCount !== 'number' ||
+          !Number.isInteger(opts.maxCount) ||
+          opts.maxCount < 0
         ) {
-          throw new TypeError('MemoryCacheStore options.maxEntries must be a non-negative integer')
+          throw new TypeError('MemoryCacheStore options.maxCount must be a non-negative integer')
         }
-        this.#maxEntries = opts.maxEntries
+        this.#maxCount = opts.maxCount
       }
 
       if (opts.maxEntrySize !== undefined) {
@@ -58,7 +58,7 @@ class MemoryCacheStore {
   }
 
   get isFull () {
-    return this.#entryCount >= this.#maxEntries
+    return this.#entryCount >= this.#maxCount
   }
 
   /**

diff --git a/types/cache-interceptor.d.ts b/types/cache-interceptor.d.ts
@@ -77,11 +77,13 @@ declare namespace CacheHandler {
     /**
        * @default Infinity
        */
-    maxEntries?: number
+    maxCount?: number
+
     /**
        * @default Infinity
        */
     maxEntrySize?: number
+
     errorCallback?: (err: Error) => void
   }