Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test against Node.js nightlies #2932

Closed
mcollina opened this issue Mar 7, 2024 · 4 comments · Fixed by #2969
Closed

test against Node.js nightlies #2932

mcollina opened this issue Mar 7, 2024 · 4 comments · Fixed by #2969
Labels
Tests Changes related to the unit tests

Comments

@mcollina
Copy link
Member

mcollina commented Mar 7, 2024

I think we should set up our CI to run against Node.js nightlies, we would have caught the regression
@Uzlopak
Copy link
Contributor

Uzlopak commented Mar 7, 2024

Maybe run against nightlies scheduled every day and if it errors it should create an issue in this repo.

Maybe also something we can motivate @mweberxyz ?

@metcoder95 metcoder95 added the Tests Changes related to the unit tests label Mar 10, 2024
@metcoder95
Copy link
Member

Maybe it can be still done on every merge to main|next, but only on code paths that are not documentation; like the idea of automatic issue creation, although it should it should be treated with care, as is possible flaky tests (not yet identified) becomes noisy causing alert fatigue

@mweberxyz
Copy link
Contributor

Yeah this kind of thing is right up my alley I'll take a look @Uzlopak

mweberxyz added a commit to mweberxyz/nodejs-undici that referenced this issue Mar 15, 2024
@mweberxyz
chore: add nightly tests
6326bf4 
Closes nodejs#2932
@mweberxyz mweberxyz mentioned this issue Mar 15, 2024
Merged
6 tasks
@mweberxyz
Copy link
Contributor

Current PR went with @Uzlopak suggestion to simply run on a schedule, and avoid @metcoder95 concerns of issue fatigue, it will not create new issues if one is already open.

@Uzlopak Uzlopak linked a pull request Mar 15, 2024 that will close this issue
Chore: run tests daily against node nightly #2969
Merged
6 tasks
Uzlopak pushed a commit that referenced this issue Mar 16, 2024
@mweberxyz
Chore: run tests daily against node nightly (#2969)
3be7ec9 
* chore(.github/workflows): factor out test running

* chore: add nightly tests

Closes #2932
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Tests Changes related to the unit tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Chore: run tests daily against node nightly mweberxyz/nodejs-undici
4 participants
@mcollina @mweberxyz @Uzlopak @metcoder95