Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automate releases #3042

Closed
mcollina opened this issue Apr 2, 2024 · 6 comments · Fixed by #3052
Closed

automate releases #3042

mcollina opened this issue Apr 2, 2024 · 6 comments · Fixed by #3052

Comments

@mcollina
Copy link
Member

mcollina commented Apr 2, 2024

as titled, we should automate our releases so we can avoid incidents like #3040

@bizob2828
Copy link
Contributor

bizob2828 commented Apr 2, 2024

does this mean 6.11.0 is in a broken state? The New Relic Node.js agent tests are failing with 6.11.0. We're getting

TypeError: request.addHeader is not a function

I see this PR removed addHeader. Breaking change as a minor?

@ronag
Copy link
Member

ronag commented Apr 2, 2024

Breaking change as a minor?

Experimental feature.

@mcollina
Copy link
Member Author

mcollina commented Apr 2, 2024

@bizob2828 if we broke something, we can always revert. Please open an issue about the breakage.

@mcollina
Copy link
Member Author

mcollina commented Apr 8, 2024

Unfortunately this is not compatible with protected branches. I've reverted the script.

Basically we need a more complex workflow, which I don't have time to develop atm.

Ideas would be welcomed at this point... I'm not entirely sure how to work around this.
A possible flow could be:

  1. action creates a PR
  2. human approves and merge the PR
  3. action releases to GH and NPM

@mweberxyz
Copy link
Contributor

I can take a look.

@mcollina
Copy link
Member Author

mcollina commented Apr 9, 2024

thx

mweberxyz added a commit to mweberxyz/nodejs-undici that referenced this issue Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants