-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v7 #3386
Comments
Shall we consider the exposure of the lenient flags from |
Yes, I think so. |
How can i support? |
is this something we're absolutely landing? Also hopefully #2727 is included in the fetch stuff, it's slightly older so I'm hoping it won't get missed. |
Would you like to support adding the lenient flags for llhttp @Uzlopak? |
I was kicking off the work for the lenient flags, but I just noticed that most of them as marked as opening a security vector if enabled; do we want to enable that within By default they are disabled sure, but do we want to expose the users to that possibility? |
Why was dropped interceptors ? What should i use instead ? |
Interceptors hasn't been dropped, but rather refactored into a new API. |
can the npm package |
That's done. On a different topic, I think we might want to release v7 before Node.js v23, to be included there. |
Backported some of the work done for interceptors and smaller fixes at core. |
Do we want to make v7 before v23 is cut? nodejs/Release#1034 |
Yes. |
Is undici@v7 going to drop support for Node.js 18.x? |
Not right now. However, if we miss the deadline for Node.js v23 (seems likely), we will definitely be dropping it, as Node.js v18 goes EOL April 2025. |
@trivikr are you arguing we should drop support for Node.js v18 or not? So far it's in and it's not causing many issues. |
I've discussed with @ronag in person how we can handle multiple dispatcher versions (even in minor releases). So those are actually not hard requirements. |
I plan to ship this on the 27th of November. |
Looking at the history of major version releases of undici and end-of-life of Node.js runtimes, it looks like undici@v7 should drop support for Node.js 18.x
Assuming v8 of undici is released in December 2025, we can think of two options for min Node.js version support.
Undici can use this data to drop support for Node.js 18.x, and push undici users to upgrade. |
Bumping for decision on supported version of Node.js. The https://github.com/nodejs/undici/releases/tag/v7.0.0-alpha.7 was released today, and stable version is expected to be released in two days. |
I have yet to see justification for dropping v18. What benefit is there in dropping it? |
As time will pass, it would be harder for us to maintain it. Right now, this means using |
I'll trust you on that, I guess I would be a -0 on dropping it. |
Should I create a new feature request for this, if maintainers are interested in coming up with a schedule? Looking at the past releases, it does not look like undici needs a release schedule. |
Overall, the |
Shall we close it? |
We start with merging the next branch into main (@metcoder95) and then start working actively on v7 with a deadline relative to Node v23.
The text was updated successfully, but these errors were encountered: