Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop node v18 #3880

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Drop node v18 #3880

merged 2 commits into from
Nov 26, 2024

Conversation

mcollina
Copy link
Member

No description provided.

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@mcollina mcollina requested a review from ronag November 25, 2024 16:17
@mcollina
Copy link
Member Author

cc @trivikr

Signed-off-by: Matteo Collina <hello@matteocollina.com>
@KhafraDev
Copy link
Member

I haven't seen any reason to drop v18. Nothing in fetch or other web specs needs it gone, and it's in maintenance mode for another 5 months. Is there any reason other than precedence? If precedence is the main concern, there were genuine issues with previous versions of node that required us to drop them - I can't think of any similar issues in v18.

@trivikr
Copy link
Member

trivikr commented Nov 25, 2024

@KhafraDev I'd provided estimates on how long unidici maintainers have to support Node.js 18.x in #3386 (comment) after it's end-of-life.
In summary, it needs to be supported for at least 6 months under the assumption that undici@v8 is released in Dec 2025.

Matteo also provided how dropping Node.js 18.x will ease maintenance of undici@v7 in #3386 (comment)

@trivikr
Copy link
Member

trivikr commented Nov 25, 2024

As per #3386 (comment) on tracking issue, @KhafraDev is -0 in dropping support for Node.js 18.x in undici@v7

Copy link
Member

@trivikr trivikr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this needs approval from a maintainer.

@ronag ronag merged commit 1b35a4e into main Nov 26, 2024
34 of 36 checks passed
@metcoder95 metcoder95 deleted the drop-node-18 branch November 26, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants