-
Notifications
You must be signed in to change notification settings - Fork 551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop node v18 #3880
Drop node v18 #3880
Conversation
Signed-off-by: Matteo Collina <hello@matteocollina.com>
cc @trivikr |
Signed-off-by: Matteo Collina <hello@matteocollina.com>
I haven't seen any reason to drop v18. Nothing in fetch or other web specs needs it gone, and it's in maintenance mode for another 5 months. Is there any reason other than precedence? If precedence is the main concern, there were genuine issues with previous versions of node that required us to drop them - I can't think of any similar issues in v18. |
@KhafraDev I'd provided estimates on how long unidici maintainers have to support Node.js 18.x in #3386 (comment) after it's end-of-life. Matteo also provided how dropping Node.js 18.x will ease maintenance of undici@v7 in #3386 (comment) |
As per #3386 (comment) on tracking issue, @KhafraDev is -0 in dropping support for Node.js 18.x in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but this needs approval from a maintainer.
No description provided.