Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dns interceptor doesn't set port in host header #3937

Closed
ronag opened this issue Dec 9, 2024 · 2 comments · Fixed by #3940
Closed

dns interceptor doesn't set port in host header #3937

ronag opened this issue Dec 9, 2024 · 2 comments · Fixed by #3940
Labels
bug Something isn't working

Comments

@ronag
Copy link
Member

ronag commented Dec 9, 2024

undici/lib/interceptor/dns.js

Line 361 in 503ad76

host: origin.hostname,

I believe this should be using host instead of hostname... otherwise we will strip the port...
@ronag ronag added the bug Something isn't working label Dec 9, 2024
@ronag
Copy link
Member Author

ronag commented Dec 9, 2024

@metcoder95

@metcoder95
Copy link
Member

Agree, missed that completely 👍

metcoder95 added a commit that referenced this issue Dec 10, 2024
@metcoder95
fix(#3937): respect correct host header
d7ec3b6
@metcoder95 metcoder95 mentioned this issue Dec 10, 2024
Merged
7 tasks
ronag pushed a commit that referenced this issue Dec 10, 2024
@metcoder95 @mcollina
fix(#3937): respect correct host header (#3940)
81416fc 
* fix(#3937): respect correct host header

* Update test/interceptors/dns.js

Co-authored-by: Matteo Collina <hello@matteocollina.com>

---------

Co-authored-by: Matteo Collina <hello@matteocollina.com>
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(#3937): respect correct host header nodejs/undici
2 participants
@ronag @metcoder95