-
Notifications
You must be signed in to change notification settings - Fork 567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(headers): iterate over cloned list #1081
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1081 +/- ##
=======================================
Coverage 95.09% 95.09%
=======================================
Files 39 39
Lines 3750 3753 +3
=======================================
+ Hits 3566 3569 +3
Misses 184 184
Continue to review full report at Codecov.
|
If you could also find ref to spec that would be great. |
From the last sentence in this section
Where sort and combine is an instruction-set for creating a new list. |
Adding another test to this PR, which is also failing in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
The infinite iteration test is a good check as well. Totally missed that; I wonder if something like that would be valuable for the web platform tests |
* chore(headers): add failing test * fix(headers): iterate over list clone * chore(headers): add test for infinite iteration
* chore(headers): add failing test * fix(headers): iterate over list clone * chore(headers): add test for infinite iteration
This matches the browser behavior, example: