Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add node 17 to test matrix #1091

Closed
wants to merge 1 commit into from
Closed

fix: add node 17 to test matrix #1091

wants to merge 1 commit into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Nov 11, 2021

Refs: #1061

@ronag ronag requested a review from mcollina November 11, 2021 07:44
@ronag ronag mentioned this pull request Nov 11, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #1091 (9cec17d) into main (3d2ce43) will decrease coverage by 0.37%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
- Coverage   95.10%   94.73%   -0.38%     
==========================================
  Files          39       39              
  Lines        3758     3758              
==========================================
- Hits         3574     3560      -14     
- Misses        184      198      +14     
Impacted Files Coverage Δ
lib/handler/redirect.js 91.13% <0.00%> (-3.80%) ⬇️
lib/core/request.js 94.85% <0.00%> (-3.68%) ⬇️
lib/fetch/util.js 87.30% <0.00%> (-1.59%) ⬇️
lib/client.js 97.31% <0.00%> (-0.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d2ce43...9cec17d. Read the comment docs.

@ronag
Copy link
Member Author

ronag commented Nov 11, 2021

@mcollina any ideas why it fails on 17?

@ronag ronag closed this Nov 12, 2021
@szmarczak
Copy link
Member

Probably #1085 I guess the certificates need to use modern TLS features. No idea how to regenerate them.

@Uzlopak Uzlopak mentioned this pull request Jan 27, 2024
7 tasks
@Uzlopak Uzlopak deleted the node17 branch February 26, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants