Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: disable FinalizationRegistry if NODE_V8_COVERAGE is set #2304

Merged

Conversation

ivan-tymoshenko
Copy link
Contributor

See #2298

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (3bfc1ba) 85.53%.
Report is 25 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2304      +/-   ##
==========================================
- Coverage   85.54%   85.53%   -0.02%     
==========================================
  Files          76       76              
  Lines        6858     6860       +2     
==========================================
+ Hits         5867     5868       +1     
- Misses        991      992       +1     
Files Coverage Δ
index-fetch.js 100.00% <100.00%> (ø)
lib/core/connect.js 83.75% <100.00%> (+2.50%) ⬆️
lib/fetch/body.js 97.67% <100.00%> (-0.02%) ⬇️
lib/fetch/global.js 100.00% <ø> (ø)
lib/pool.js 100.00% <100.00%> (ø)
lib/websocket/connection.js 89.15% <100.00%> (+0.13%) ⬆️
lib/websocket/frame.js 100.00% <100.00%> (ø)
lib/client.js 93.03% <66.66%> (-0.09%) ⬇️
lib/core/util.js 94.73% <85.71%> (-1.06%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcollina mcollina merged commit 7c2486d into nodejs:main Oct 3, 2023
18 checks passed
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants