Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: :status is not a string #2423

Closed
wants to merge 1 commit into from
Closed

Conversation

tsctx
Copy link
Member

@tsctx tsctx commented Nov 11, 2023

This relates to...

Rationale

The pseudo-headers :status numeric and must be converted to a string.

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@tsctx
Copy link
Member Author

tsctx commented Nov 11, 2023

cc @KhafraDev

@codecov-commenter
Copy link

codecov-commenter commented Nov 11, 2023

Codecov Report

Attention: 22 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (be97968) 85.85%.
Report is 87 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2423      +/-   ##
==========================================
+ Coverage   85.54%   85.85%   +0.30%     
==========================================
  Files          76       76              
  Lines        6858     6912      +54     
==========================================
+ Hits         5867     5934      +67     
+ Misses        991      978      -13     
Files Coverage Δ
index-fetch.js 100.00% <100.00%> (ø)
lib/api/api-stream.js 100.00% <100.00%> (ø)
lib/core/connect.js 81.25% <100.00%> (ø)
lib/fetch/body.js 97.68% <100.00%> (ø)
lib/fetch/constants.js 97.22% <100.00%> (+0.67%) ⬆️
lib/fetch/file.js 95.45% <100.00%> (+0.05%) ⬆️
lib/fetch/global.js 100.00% <ø> (ø)
lib/fetch/response.js 97.04% <100.00%> (+1.20%) ⬆️
lib/fetch/util.js 86.53% <100.00%> (+0.71%) ⬆️
lib/fetch/webidl.js 94.50% <100.00%> (-0.03%) ⬇️
... and 10 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I mentioned in my comment, pseudo (pseudo being synonymous with "fake") headers are not header fields, and shouldn't be treated as such. The issue is therefore no longer with fetch, but with how undici handles pseudo headers.

@tsctx
Copy link
Member Author

tsctx commented Nov 11, 2023

@KhafraDev
I understand. I will close this PR.

@tsctx tsctx closed this Nov 11, 2023
@tsctx tsctx deleted the fix/header-number branch November 11, 2023 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants