Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: version cleanup #2507

Merged
merged 2 commits into from
Dec 7, 2023
Merged

refactor: version cleanup #2507

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9e5e9d4
refactor: version cleanup
tsctx Dec 6, 2023
ed9ca26
remove throwIfAborted
tsctx Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 2 additions & 25 deletions lib/core/util.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,19 +334,11 @@ function isDisturbed (body) {
}

function isErrored (body) {
return !!(body && (
stream.isErrored
? stream.isErrored(body)
: /state: 'errored'/.test(nodeUtil.inspect(body)
)))
return !!(body && stream.isErrored(body))
}

function isReadable (body) {
return !!(body && (
stream.isReadable
? stream.isReadable(body)
: /state: 'readable'/.test(nodeUtil.inspect(body)
)))
return !!(body && stream.isReadable(body))
}

function getSocketInfo (socket) {
Expand Down Expand Up @@ -411,20 +403,6 @@ function isFormDataLike (object) {
)
}

function throwIfAborted (signal) {
if (!signal) { return }
if (typeof signal.throwIfAborted === 'function') {
signal.throwIfAborted()
} else {
if (signal.aborted) {
// DOMException not available < v17.0.0
const err = new Error('The operation was aborted')
err.name = 'AbortError'
throw err
}
}
}

function addAbortListener (signal, listener) {
if ('addEventListener' in signal) {
signal.addEventListener('abort', listener, { once: true })
Expand Down Expand Up @@ -495,7 +473,6 @@ module.exports = {
getSocketInfo,
isFormDataLike,
buildURL,
throwIfAborted,
addAbortListener,
parseRangeHeader,
nodeMajor,
Expand Down
Loading