Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port cookies tests to node runner #2547

Merged
merged 6 commits into from
Dec 28, 2023
Merged

feat: port cookies tests to node runner #2547

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d080276
feat: port cookies test to node runner
Dec 28, 2023
8581e1a
feat: add borp
Dec 28, 2023
9713fb3
feat: rebase
Dec 28, 2023
560da3a
apply suggestion
pmarchini Dec 28, 2023
c0dc9c7
feat: remove unused t
Dec 28, 2023
cfe4e87
feat: add pattern flag to test:cookies script
Dec 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@
"lint": "standard | snazzy",
"lint:fix": "standard --fix | snazzy",
"test": "node scripts/generate-pem && npm run test:tap && npm run test:node-fetch && npm run test:fetch && npm run test:cookies && npm run test:wpt && npm run test:websocket && npm run test:jest && npm run test:typescript",
"test:cookies": "tap test/cookie/*.js",
"test:cookies": "borp --coverage test/cookie/*.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"test:cookies": "borp --coverage test/cookie/*.js",
"test:cookies": "borp --coverage \"test/cookie/*.js\"",

This will fix windows

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big question why this is needed for borp and not for tap

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

big question why this is needed for borp and not for tap

I'll take a look at it

"test:node-fetch": "mocha --exit test/node-fetch",
"test:fetch": "npm run build:node && tap --expose-gc test/fetch/*.js && tap test/webidl/*.js",
"test:jest": "jest",
Expand All @@ -100,6 +100,7 @@
"@types/node": "^18.0.3",
"abort-controller": "^3.0.0",
"atomic-sleep": "^1.0.0",
"borp": "^0.4.2",
"chai": "^4.3.4",
"chai-as-promised": "^7.1.1",
"chai-iterator": "^3.0.2",
Expand Down
Loading
Loading