Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove anti-pattern dispatcher hooks #2723

Merged
merged 1 commit into from
Feb 10, 2024
Merged

remove anti-pattern dispatcher hooks #2723

merged 1 commit into from
Feb 10, 2024

Commits on Feb 9, 2024

  1. remove anti-pattern dispatcher hooks 

    onBodySent on onRequestSent are footguns that easily cause bugs
when implementing logic will send multiple requests, e.g. redirect
and retry.

To achieve similar functionality wrap body into a stream and listen
to 'data' and 'end' events.

Refs: #2722
    @ronag
    ronag committed Feb 9, 2024
    Configuration menu
    Copy the full SHA
    b8103e6 View commit details
    Browse the repository at this point in the history