Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core: sync next with main #2757

Closed
wants to merge 7 commits into from
Closed

core: sync next with main #2757

wants to merge 7 commits into from

Conversation

metcoder95
Copy link
Member

@metcoder95 metcoder95 commented Feb 14, 2024

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@ronag
Copy link
Member

ronag commented Feb 14, 2024

isn't it easier to just cherry-pick all commits from main on top of next?

@metcoder95
Copy link
Member Author

Kind of, but just wanted to have another pair of eyes on it given that we adjust a lot of tests and other pieces that overlap quite heavily 😅

@metcoder95 metcoder95 marked this pull request as ready for review February 16, 2024 11:26
@metcoder95
Copy link
Member Author

The biggest conflicts were the testing, the remains seem to be the same

@ronag
Copy link
Member

ronag commented Feb 16, 2024

I fixed this.

@ronag ronag closed this Feb 16, 2024
@Uzlopak Uzlopak deleted the core/sync-next branch February 21, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants