Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: optimize one element splice operation #2809

Closed

Conversation

tsctx
Copy link
Member

@tsctx tsctx commented Feb 22, 2024

Reopening #2718. It was closed by mistake.

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e39a632) 85.54% compared to head (926a0c3) 85.60%.
Report is 334 commits behind head on main.

Files Patch % Lines
lib/web/cache/cache.js 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2809      +/-   ##
==========================================
+ Coverage   85.54%   85.60%   +0.05%     
==========================================
  Files          76       87      +11     
  Lines        6858     7706     +848     
==========================================
+ Hits         5867     6597     +730     
- Misses        991     1109     +118     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ronag ronag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is way too micro optimization.

@tsctx
Copy link
Member Author

tsctx commented Feb 22, 2024

Ah. I see.

@tsctx tsctx closed this Feb 22, 2024
@tsctx tsctx deleted the perf/optimize-one-element-splice-operation branch February 22, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants