fix fetch support for node < 18.14.0 #3124
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3124 +/- ##
==========================================
- Coverage 94.18% 94.09% -0.10%
==========================================
Files 89 89
Lines 24379 24418 +39
==========================================
+ Hits 22962 22975 +13
- Misses 1417 1443 +26 ☔ View full report in Codecov by Sentry. |
ronag
approved these changes
Apr 15, 2024
|
I'm making an alternative to this PR to drop node support for < v18.17.0 |
|
#3125 is a better solution IMO, also lets us drop the entire custom File implementation. |
mcollina
requested changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3123
I'm wondering if we should drop support for node < v18.17.0. The person who reported it mentioned that we can't run the test suite, so there's no way to guarantee that old v18 versions stay supported.