Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix casing issue when cloning Headers object (#3160)" #3161

Closed
wants to merge 2 commits into from

Conversation

tsctx
Copy link
Member

@tsctx tsctx commented Apr 24, 2024

@tsctx tsctx requested a review from KhafraDev April 24, 2024 20:36
@tsctx tsctx changed the title Revert 3160 webidl headersinit Revert "fix casing issue when cloning Headers object (#3160)" Apr 24, 2024
Copy link
Member

@KhafraDev KhafraDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be easily fixable by fixing .entries

get entries () {
?

@tsctx
Copy link
Member Author

tsctx commented Apr 24, 2024

It's impossible because it's an object. It must be an array.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.13%. Comparing base (034e3f0) to head (1d49f97).

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #3161       +/-   ##
=========================================
+ Coverage      0   94.13%   +94.13%     
=========================================
  Files         0       90       +90     
  Lines         0    24309    +24309     
=========================================
+ Hits          0    22883    +22883     
- Misses        0     1426     +1426     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KhafraDev
Copy link
Member

We could probably use kHeadersSortedMap (how the iterators run) instead. The webidl part can return an array too.

@KhafraDev
Copy link
Member

I'll take a look at it in a few hours, fixing it from my point of view doesn't seem too difficult.

@tsctx
Copy link
Member Author

tsctx commented Apr 24, 2024

This seems not the best solution.

@tsctx tsctx closed this Apr 24, 2024
@tsctx tsctx deleted the revert-3160-webidl-headersinit branch April 24, 2024 21:33
@tsctx tsctx mentioned this pull request Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants