Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: streamline test scripts in regard of without-intl and run more tests for without-intl case #3453

Merged
merged 2 commits into from
Aug 14, 2024
Merged

test: streamline test scripts in regard of without-intl and run more tests for without-intl case #3453

merged 2 commits into from
Aug 14, 2024
+10 −8

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 13, 2024

streamline the test scripts and also run e.g. websocket tests.

@Uzlopak
Copy link
Contributor Author

Uzlopak commented Aug 13, 2024

I fixed it already locally but forgot to push..

@Uzlopak Uzlopak marked this pull request as draft August 13, 2024 05:05
@Uzlopak Uzlopak marked this pull request as ready for review August 13, 2024 15:29
mcollina
mcollina approved these changes Aug 14, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 5b7f372 into nodejs:main Aug 14, 2024
32 checks passed
@Uzlopak Uzlopak deleted the run-all-test-without-intl branch October 12, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@KhafraDev KhafraDev Awaiting requested review from KhafraDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Uzlopak @mcollina