Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport v6.x] fix: use fasttimers for all connection timeouts #3675

Merged
merged 1 commit into from
Oct 4, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 4, 2024

Backport dca0aa0 from #3552.

* fix: use fasttimers for all connection timeouts

* Apply suggestions from code review

* activate some tests

* also use fastTimers in connect.js

* fix tests

* fix tests

* fix tests

* fix: use native timeouts for TIMEOUT_IDLE, rename TIMEOUT_IDLE to TIMEOUT_KEEP_ALIVE (#3554)

* fix: use native timeouts for TIMEOUT_IDLE, rename TIMEOUT_IDLE to TIMEOUT_KEEP_ALIVE

* ensure that fast timers and native timers are set properly

* .

* .

* rename import

* more informative connection error

* ignore request-timeout binary file, rename clearAll to reset

* fix

* add test

* use queueMicrotask earlier in the socket callbacks

(cherry picked from commit dca0aa0)
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants