Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle undefined deref() of WeakRef(socket) #3751

Merged
merged 4 commits into from
Nov 11, 2024
Merged

fix: handle undefined deref() of WeakRef(socket) #3751

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c9c07b3
fix: handle undefined deref of weakref socket
hochoy Oct 20, 2024
022e2ef
exit early
Uzlopak Nov 3, 2024
adfc4f7
Merge branch 'main' into handled-undefined-socket-in-onconnectimeout
Uzlopak Nov 3, 2024
ad1a2e6
Merge branch 'main' into handled-undefined-socket-in-onconnectimeout
Uzlopak Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions lib/core/connect.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,11 @@ const setupConnectTimeout = process.platform === 'win32'
* @param {number} opts.port
*/
function onConnectTimeout (socket, opts) {
// The socket could be already garbage collected
if (socket == null) {
return
}

let message = 'Connect Timeout Error'
if (Array.isArray(socket.autoSelectFamilyAttemptedAddresses)) {
message += ` (attempted addresses: ${socket.autoSelectFamilyAttemptedAddresses.join(', ')},`
Expand Down
Loading