feat: use resolved ports in dns interceptor #3786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Support custom functions that resolve e.g. SRV records with ports
metcoder95
reviewed
Oct 29, 2024
metcoder95
approved these changes
Oct 30, 2024
flakey5
pushed a commit
to flakey5/undici
that referenced
this pull request
Nov 14, 2024
Co-authored-by: Carlos Fuentes <me@metcoder.dev>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
DNS interceptor
Rationale
Support custom functions that resolve both IP addresses and ports. It can be used e.g. with
dns.resolveSrvfollowed bydns.resolve.Changes
Change priority of the port used to:
Features
Use port on resolved address.
Bug Fixes
Breaking Changes and Deprecations
Status