Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: publish undici:client:sendHeaders message on H2 #3921

Merged
merged 1 commit into from
Dec 3, 2024
Merged

fix: publish undici:client:sendHeaders message on H2 #3921

merged 1 commit into from
Dec 3, 2024

Conversation

fengmk2
Copy link
Contributor

@fengmk2 fengmk2 commented Dec 3, 2024 •
edited
Loading

This relates to...

Rationale

Changes

Features

Bug Fixes

Add undici:client:sendHeaders message back on H2 request

Breaking Changes and Deprecations

Status

@fengmk2
fix: publish undici:client:sendHeaders message on H2
7326aa7 
Signed-off-by: fengmk2 <fengmk2@gmail.com>
mcollina
mcollina approved these changes Dec 3, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metcoder95 metcoder95 merged commit e4245ec into nodejs:main Dec 3, 2024
30 of 31 checks passed
@fengmk2 fengmk2 deleted the fix-missing-sendHeaders-event-on-h2 branch December 4, 2024 00:57
@fengmk2 fengmk2 mentioned this pull request Dec 4, 2024
Closed
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metcoder95 metcoder95 metcoder95 approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fengmk2 @mcollina @metcoder95