fix: throw on GET & HEAD request body #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
commented
May 3, 2020
| @@ -70,13 +70,14 @@ class Request extends AsyncResource { | |||
| } | |||
| this.path = opts.path | |||
|
|
|||
| // TODO we should validate that the http method accepts a body or not | |||
| if (!isValidBody(opts.body)) { | |||
| if (opts.body && (this.method === 'GET' || this.method === 'HEAD')) { | |||
There was a problem hiding this comment.
I think HEAD and GET are the only methods where a body is not allowed?
|
Close due to discussion in #35 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.