fix websocket basic auth #4747
Merged
fix websocket basic auth #4747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4747 +/- ##
==========================================
+ Coverage 92.89% 92.94% +0.04%
==========================================
Files 109 109
Lines 33886 33981 +95
==========================================
+ Hits 31478 31582 +104
+ Misses 2408 2399 -9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
metcoder95
approved these changes
Jan 19, 2026
Merged
killagu
added a commit
to killagu/undici
that referenced
this pull request
Jan 22, 2026
`isTraversableNavigable()` was returning `true` unconditionally, which caused an infinite retry loop when the server responded with 401. In Node.js environment, there is no traversable navigable that can prompt the user for credentials (unlike browsers). The 401 retry logic at step 14 of HTTP-network-or-cache fetch requires user interaction to provide credentials, which is not possible in Node.js. Returning `false` disables the incomplete 401 retry logic that was causing the infinite loop, while preserving the URL credentials functionality added in nodejs#4747. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4744