Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for issue 583. #822

Merged
merged 1 commit into from
Jun 6, 2021
Merged

Add tests for issue 583. #822

merged 1 commit into from
Jun 6, 2021

Conversation

mcollina
Copy link
Member

@mcollina mcollina commented Jun 6, 2021

Closes #583

@codecov-commenter
Copy link

codecov-commenter commented Jun 6, 2021

Codecov Report

Merging #822 (9411084) into main (b33dffa) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #822   +/-   ##
=======================================
  Coverage   99.70%   99.70%           
=======================================
  Files          26       26           
  Lines        2036     2036           
=======================================
  Hits         2030     2030           
  Misses          6        6           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33dffa...9411084. Read the comment docs.

@mcollina
Copy link
Member Author

mcollina commented Jun 6, 2021

Let's wait for confirmation that the problem is fixed.

@ronag
Copy link
Member

ronag commented Jun 6, 2021

@mcollina i think we are good here

@mcollina mcollina merged commit 6aaff7d into main Jun 6, 2021
@Uzlopak Uzlopak deleted the fix-583 branch February 21, 2024 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SocketError: other side closed
3 participants