-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: return body as consumable body2 #898
Conversation
Codecov Report
@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 99.57% 97.66% -1.92%
==========================================
Files 26 27 +1
Lines 2132 2184 +52
==========================================
+ Hits 2123 2133 +10
- Misses 9 51 +42
Continue to review full report at Codecov.
|
4f1c2ad
to
5370b6c
Compare
c43d516
to
344bae6
Compare
41dd0a6
to
7068f35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this seems less breaking. Does it wreck our perf?
Perf seems same: main [bench:run] │ Tests │ Samples │ Result │ Tolerance │ Difference with slowest │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ http - no keepalive │ 10 │ 6.34 req/sec │ ± 0.65 % │ - │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ http - keepalive │ 10 │ 7.06 req/sec │ ± 1.34 % │ + 11.30 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - pipeline │ 10 │ 64.81 req/sec │ ± 1.02 % │ + 922.39 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - stream │ 10 │ 68.68 req/sec │ ± 1.76 % │ + 983.36 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - dispatch │ 10 │ 68.86 req/sec │ ± 1.53 % │ + 986.29 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - request │ 10 │ 70.51 req/sec │ ± 2.01 % │ + 1012.25 % │ PR [bench:run] │ Tests │ Samples │ Result │ Tolerance │ Difference with slowest │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ http - no keepalive │ 10 │ 6.34 req/sec │ ± 0.72 % │ - │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ http - keepalive │ 10 │ 7.00 req/sec │ ± 1.41 % │ + 10.48 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - pipeline │ 10 │ 63.50 req/sec │ ± 0.90 % │ + 902.15 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - stream │ 10 │ 66.57 req/sec │ ± 1.58 % │ + 950.58 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - request │ 10 │ 70.15 req/sec │ ± 2.18 % │ + 1007.15 % │
[bench:run] |─────────────────────|─────────|───────────────|───────────|─────────────────────────|
[bench:run] │ undici - dispatch │ 10 │ 72.62 req/sec │ ± 1.55 % │ + 1046.09 % │ |
I've reduced the ambition here. Remove the hacky performance part and focus on API and functionality to begin with. |
Also opened against node core. Waiting for feedback there as well. |
I think it's likely we will land a better version in node core. nodejs/node#39520 |
This is an alternative variant solving some problems with the previous PR.
It's a little hacky but I think it can work out. Thoughts?