Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore failures building all recipes but fetch-source #10

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

joaocgreis
Copy link
Member

v12.11.0 was not published because of a failure building x86. Until that is fixed it is blocking other recipes and promotion of assets. This PR changes build.sh to keep building other recipes when one fails.

This was not tested, I will fix any issue if we agree this is the way to move forward.

cc @rvagg

@richardlau
Copy link
Member

v12.11.0 was not published because of a failure building x86. Until that is fixed it is blocking other recipes and promotion of assets.

Unofficial builds of v12.11.0 failed because they build from the source tarball which is broken (nodejs/node#29709). nodejs/node#29712 fixed the source tarball generation but would need a new release.

That's not to say the idea here of not allowing one failing recipe to block the others isn't a good idea.

@rvagg
Copy link
Member

rvagg commented Oct 1, 2019

yeah, what @richardlau said, I manually edited this file on the server and removed x86 and then musl failed, which is why nodejs/node#29709 turned from "x86 is broken" to "it's all broken". But you're right, this has been a TODO

@rvagg rvagg merged commit d6fba84 into nodejs:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants