Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: suppress warnings in uvwasi.c #70

Merged
merged 4 commits into from
Jan 10, 2020
Merged

src: suppress warnings in uvwasi.c #70

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
85ed5fc
src: suppress warnings in uvwasi.c
HarshithaKP Jan 6, 2020
f56e817
fixup: address review comment
HarshithaKP Jan 9, 2020
b0903d9
fixup: fix incorrect source
HarshithaKP Jan 10, 2020
80bf97c
fixup: address review comment
HarshithaKP Jan 10, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ if(APPLE)
set(CMAKE_MACOSX_RPATH ON)
endif()

if(CMAKE_SYSTEM_NAME STREQUAL "Linux")
list(APPEND uvwasi_defines _GNU_SOURCE _POSIX_C_SOURCE=200112)
list(APPEND uvwasi_sources src/unix/linux-core.c)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this line being added by mistake?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@addaleax , Thanks. That was a mistake. I meant to add uvwasi.c, based on my understanding about CMAKE that it will be subjected for _GNU_SOURCE macro definition. I corrected that now.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need to specify the source file, that's already done elsewhere. Take a look at libuv's CMakeList.txt, specifically the target_compile_definitions stanza. You need to add one for the uvwasi_a target.

endif()

include(FetchContent)
## https://libuv.org
FetchContent_Declare(
Expand Down